Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plugin.video.orange.fr] 2.3.1 #4581

Open
wants to merge 1 commit into
base: omega
Choose a base branch
from

Conversation

f-lawe
Copy link

@f-lawe f-lawe commented Oct 11, 2024

Description

  • Update to InputstreamAdaptive for Kodi 21
  • Avoid re-authentication when stored session data is not expired
  • Better error management
  • Routing and provider interface now allow various depths in catchup menus

Checklist:

  • My code follows the add-on rules and piracy stance of this project.
  • I have read the CONTRIBUTING document
  • Each add-on submission should be a single commit with using the following style: [plugin.video.foo] v1.0.0

Additional information :

  • Submitting your add-on to this specific branch makes it available to any Kodi version equal or higher than the branch name with the applicable Kodi dependencies limits.
  • add-on development wiki page.
  • Kodi pydocs provide information about the Python API
  • PEP8 codingstyle which is considered best practice but not mandatory.
  • This add-on repository has automated code guideline check which could help you improve your coding. You can find the results of these check at Codacy. You can create your own account as well to continuously monitor your python coding before submitting to repo.
  • Development questions can be asked in the add-on development section on the Kodi forum.
  • If you see no activity on your PR after a week (so at least one weekend has passed) then please go to the #kodi-dev freenode IRC channel to reach out to the team

@f-lawe
Copy link
Author

f-lawe commented Oct 11, 2024

Is it ok to create a PR against omega branch? It looks empty...

@f-lawe f-lawe changed the title [plugin.video.orange.fr] 2.3.0 [plugin.video.orange.fr] 2.3.1 Oct 12, 2024
@basrieter
Copy link
Contributor

basrieter commented Oct 17, 2024

Is there any reason why you are PR-en this to the omega branch and not the nexus branch in which version 2.2.0 already exists?

If the change do not require omega-features, PR-ing it to nexus will make life a lot easier.

Possible fixes would also get pushed to Nexus users that way.

@f-lawe
Copy link
Author

f-lawe commented Oct 21, 2024

I simply followed the new Inputstream Adaptive implementation, anticipating that the current implementation won't last.

I can revert to the previous implementation if that's easier from your side and wait for Kodi 22 and jump directly to the new API. It will indeed allow Nexus users to get those updates, but there will be a breaking update at some point anyway. Question is mainly when!

@f-lawe
Copy link
Author

f-lawe commented Nov 5, 2024

Hello @basrieter!
Quick up ;) I saw that the Piers branch has been created. If that's ok for you, I can update directly to Inputstream Adaptive 22.x. Let me know what you guys prefer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants