Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fonts to related language addons #190

Open
wants to merge 2 commits into
base: nexus
Choose a base branch
from

Conversation

AlwinEsch
Copy link
Member

Description

This adds some TTF files in order to have the corresponding character type for upcoming changes in Kodi in the respective language.

The background is that Kodi does not support the characters in very many languages and could only be fixed in a few using "Arial.ttf".
Think about relocating it here, as it is needed in the respective language and so as not to flood Kodi when everyone was in it.

Checklist:

  • My code follows the add-on rules and piracy stance of this project.
  • I have read the CONTRIBUTING document
  • Each add-on submission should be a single commit with using the following style: [plugin.video.foo] v1.0.0

Additional information :

  • Submitting your add-on to this specific branch makes it available to any Kodi version equal or higher than the branch name with the applicable Kodi dependencies limits.
  • add-on development wiki page.
  • Kodi pydocs provide information about the Python API
  • PEP8 codingstyle which is considered best practice but not mandatory.
  • This add-on repository has automated code guideline check which could help you improve your coding. You can find the results of these check at Codacy. You can create your own account as well to continuously monitor your python coding before submitting to repo.
  • Development questions can be asked in the add-on development section on the Kodi forum.

@AlwinEsch
Copy link
Member Author

About the other fonts I created:

Because of the "resource.font.active" has to be kept under observation a little (if moved to Kodi), if the associated language comes in here, it would have to be moved from there to here.

@gade01
Copy link

gade01 commented Nov 27, 2021

How will this work when skins provide the fonts?
Will these fonts provided with the language addons override the fonts provided with the skins?

@AlwinEsch
Copy link
Member Author

The skin is always as primary, only in case the wanted character becomes not found there, does it a fallback to this ones on language addons.

See on https://github.com/AlwinEsch/kodi/blob/fix-estuary-strings/xbmc/guilib/GUIFontTTF.cpp#L1231-L1233
The m_fontMain there relates to them where skin bring/selected.

@gade01
Copy link

gade01 commented Nov 27, 2021

@AlwinEsch That sounds really great.
I have been struggeling with adding fonts for several languages not using regular characters for years.
So this is a great solution! ;)

noto_license.txt Outdated Show resolved Hide resolved
@AlwinEsch
Copy link
Member Author

Is updated and also added on second commit, additional font addons to allow Kodi in his use case the availability.

@@ -6,6 +6,7 @@
provider-name="Team Kodi">
<requires>
<import addon="kodi.resource" version="1.0.0"/>
<import addon="resource.language.zh_cn" version="9.0.0"/> <!-- To get his font file about where support all -->
Copy link
Member Author

@AlwinEsch AlwinEsch Jan 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is added new to get on zh_tw and ja_jp the font file from zh_cn where contains mostly all.

Bad is that on NotoSansJP-Regular.ttf and NotoSansTC-Regular.ttf also some where not on other, thats why also inside here another one.

@gade01
Copy link

gade01 commented May 13, 2022

@AlwinEsch What is required for this PR to get merged?
Core support?

This adds some TTF files in order to have the corresponding character type for upcoming changes in Kodi in the respective language.

The background is that Kodi does not support the characters in very many languages and could only be fixed in a few using "Arial.ttf".
Think about relocating it here, as it is needed in the respective language and so as not to flood Kodi when everyone was in it.
With here are 3 font addons added:
- resource.font.active Fonts to active used characters
- resource.font.excluded Fonts to no more active charactes on world
- resource.font.limited Fonts to active, but with less usage
- resource.font.coloremoji Font about colored emoji's
@AlwinEsch
Copy link
Member Author

How we see the state about this? Maybe we can bring in and have ready for the request in Kodi?

@gade01 It can be come in before. The fonts inside here, then currently not used, but prepared for the request in Kodi (xbmc/xbmc#20552)

@gade01
Copy link

gade01 commented Sep 8, 2022

It looks great to me, but perhaps I'm not the right person to review this. :)

@enen92 enen92 closed this May 13, 2023
@enen92 enen92 reopened this May 13, 2023
@enen92 enen92 closed this May 13, 2023
@enen92 enen92 reopened this May 13, 2023
@enen92
Copy link
Member

enen92 commented May 13, 2023

@AlwinEsch please check addon-checker errors, it looks like the icons you specify on addon.xml do not exist.
I am also wondering if the font files should not be font addons instead, and those font addons specified as dependencies for the language addons

@scott967
Copy link

I tested these for the CJK variants back when the core PR was fresh and the language resources did work as expected. Not sure anything gained by splitting out the fonts as the way the fonts are designed is language-specific. Unless a skin/addon provides complete coverage in a skin-provided font, then the language font is not needed. I think xbmc/xbmc#20552 needs a rebase to really test this again?

@AlwinEsch
Copy link
Member Author

@AlwinEsch please check addon-checker errors, it looks like the icons you specify on addon.xml do not exist. I am also wondering if the font files should not be font addons instead, and those font addons specified as dependencies for the language addons

About the reason to combine the font with language is mainly to have on language switch immediately the needed font available, without it can come that the language is switched and user becomes asked for font and not readable then.
But I look with font add-on as dependency of language add-on, maybe it works.

I make on next days a rebase about the font pull requests and to become ready for use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants