Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[script.black.bars.never] 1.0.11 #2638

Closed

Conversation

osumoclement
Copy link

Description

This is an addon that eliminates black bars on KODI, whether hardcoded or the video is just wide format

Checklist:

  • My code follows the add-on rules and piracy stance of this project.
  • I have read the CONTRIBUTING document
  • Each add-on submission should be a single commit with using the following style: [script.foo.bar] 1.0.0

Additional information :

  • Submitting your add-on to this specific branch makes it available to any Kodi version equal or higher than the branch name with the applicable Kodi dependencies limits.
  • add-on development wiki page.
  • Kodi pydocs provide information about the Python API
  • PEP8 codingstyle which is considered best practise but not mandatory.
  • This add-on repository has automated code guideline check which could help you improve your coding. You can find the results of these check at Codacy. You can create your own account as well to continuously monitor your python coding before submitting to repo.
  • Development questions can be asked in the add-on development section on the Kodi forum.

</extension>
<extension point="xbmc.addon.metadata">
<platform>all</platform>
<summary lang="en">BlackBarsNever</summary>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use 4-letter ll_CC language codes

<description lang="en">This addon eliminates the problem of black bars. If the black bars are hardcoded, the addon will automatically
detect this and remove them. If the video is a wide screen format, the addon will also detect this and remove the black bars too.
</description>
<license>GNU General Public License, v2</license>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use SPDX a license identifier: https://spdx.org/licenses/

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is better to move all this code into an importable module leaving only a minimal entrypoint script. This will speed-up addon start on slower systems like single-board computers.

@osumoclement osumoclement force-pushed the script.black.bars.never-matrix branch 16 times, most recently from 8402917 to 20373ce Compare September 9, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants