-
-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pr fix #199
base: master
Are you sure you want to change the base?
Pr fix #199
Conversation
@xcarpentier can we get this merged? need help? |
I'd love to see Android working again, have had to revert to a new system |
"version": "4.1.1", | ||
"description": "PDF reader for Expo", | ||
"main": "node_modules/expo/AppEntry.js", | ||
"name": "@valli_/rn-pdf-reader-js", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you change the name of the package that won't publish in the right place ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working, thanks a lot!
I tried installing the library with the changed package name ( iOSAndroidHow can this be fixed in the forked repo? I wanted to post an issue on Valli-'s fork repo, but he has Issues disabled. And I can't mention him here either. I could fork his fork and make the correction myself (I'd need to confirm that changing the package name is the only issue), but would that be ok? I have a hunch it might seem unethical. |
No description provided.