Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr fix #199

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Pr fix #199

wants to merge 3 commits into from

Conversation

xcarpentier
Copy link
Owner

No description provided.

@victoralmeidadev
Copy link

@xcarpentier can we get this merged? need help?

@GrahamEvans31
Copy link

I'd love to see Android working again, have had to revert to a new system

"version": "4.1.1",
"description": "PDF reader for Expo",
"main": "node_modules/expo/AppEntry.js",
"name": "@valli_/rn-pdf-reader-js",
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you change the name of the package that won't publish in the right place ;)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working, thanks a lot!

@Zcehtro
Copy link

Zcehtro commented Feb 2, 2024

I tried installing the library with the changed package name (@valli_/rn-pdf-reader-js instead of rn-pdf-reader-js) and it threw an error at build time, on both platforms, using Expo's eas build:

iOS

image

Android

image

How can this be fixed in the forked repo? I wanted to post an issue on Valli-'s fork repo, but he has Issues disabled. And I can't mention him here either.

I could fork his fork and make the correction myself (I'd need to confirm that changing the package name is the only issue), but would that be ok? I have a hunch it might seem unethical.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants