Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

many: start session ID at 1, dont keep track #34

Merged
merged 1 commit into from
May 11, 2024
Merged

many: start session ID at 1, dont keep track #34

merged 1 commit into from
May 11, 2024

Conversation

om26er
Copy link
Member

@om26er om26er commented May 11, 2024 •
edited
Loading

  • start session scope IDs at 1
  • don't keep track of session IDs
  • Start session IDs from 1 instead of 100_000

closes #33

@om26er om26er requested a review from rubyonrails3 May 11, 2024 14:08
@om26er om26er merged commit 6f32283 into main May 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rubyonrails3 rubyonrails3 rubyonrails3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ID generator should not keep track of old IDs
2 participants
@om26er @rubyonrails3