Add generic message validator #44
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/wampproto/message/util.rb
Outdated
| :options, :details, :subscription_id, :publication_id, | ||
| :registration_id | ||
|
|
||
| def initialize # rubocop:disable Metrics/MethodLength, Metrics/AbcSize |
There was a problem hiding this comment.
@Mahad-10 you can remove the initializer method, as what is happening the initializer is the default.
when you have attr_accessor :attribute_name
by default @attribute_name will be nil
Mahad-10
force-pushed
the
generic-message-validator
branch
from
baf5385 to
e9eef90
Compare
Mahad-10
force-pushed
the
generic-message-validator
branch
2 times, most recently
from
bdfa9d0 to
393c6cc
Compare
Mahad-10
force-pushed
the
generic-message-validator
branch
from
422065d to
d3db738
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.