refactor: remove redundant code and make code more readable #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning Review failedThe pull request is closed. WalkthroughThe changes in Changes
Sequence Diagram(s) (Beta)sequenceDiagram
participant User
participant MobileHomeScaffoldState
participant TabController
participant Provider
User ->> MobileHomeScaffoldState: Open Mobile Home Screen
MobileHomeScaffoldState ->> TabController: _initializeTabController()
MobileHomeScaffoldState ->> MobileHomeScaffoldState: _updateTabController()
User ->> MobileHomeScaffoldState: Add/Remove Tab
MobileHomeScaffoldState ->> TabController: Update Tabs
User ->> MobileHomeScaffoldState: Perform Action (e.g., Publish, Call)
MobileHomeScaffoldState ->> Provider: Handle Action
Provider ->> MobileHomeScaffoldState: Return Results
MobileHomeScaffoldState ->> User: Display Results
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
Outside diff range and nitpick comments (1)
lib/screens/mobile/mobile_home.dart (1)
140-142: The methods_showRouterDialogand_showCloseRouterDialoghandle UI dialog interactions well, but consider separating UI logic from business logic.Also applies to: 208-251
lib/screens/mobile/mobile_home.dart
Outdated
Comment on lines
521
to
532
| Future<void> _handleButtonPress(Future<void> Function() action) async { | ||
| try { | ||
| await action(); | ||
| } on Exception catch (error) { | ||
| scaffoldMessenger.showSnackBar( | ||
| SnackBar( | ||
| content: Text("$sendButton Error: $error"), | ||
| duration: const Duration(seconds: 3), | ||
| ), | ||
| ); | ||
| } | ||
| } |
There was a problem hiding this comment.
The methods _handleButtonPress and _publish are tightly coupled with UI operations. Consider using a more decoupled approach for error handling and business logic.
- Future<void> _handleButtonPress(Future<void> Function() action) async {
- try {
- await action();
- } on Exception catch (error) {
- scaffoldMessenger.showSnackBar(
- SnackBar(
- content: Text("$sendButton Error: $error"),
- duration: const Duration(seconds: 3),
- ),
- );
- }
- }
+ Future<void> _executeAction(Future<void> Function() action, String actionName) async {
+ try {
+ await action();
+ scaffoldMessenger.showSnackBar(
+ SnackBar(
+ content: Text("$actionName Successful"),
+ duration: const Duration(seconds: 3),
+ ),
+ );
+ } on Exception catch (error) {
+ scaffoldMessenger.showSnackBar(
+ SnackBar(
+ content: Text("$actionName Error: $error"),
+ duration: const Duration(seconds: 3),
+ ),
+ );
+ }
+ }Also applies to: 534-559
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
Suggested change
| Future<void> _handleButtonPress(Future<void> Function() action) async { | |
| try { | |
| await action(); | |
| } on Exception catch (error) { | |
| scaffoldMessenger.showSnackBar( | |
| SnackBar( | |
| content: Text("$sendButton Error: $error"), | |
| duration: const Duration(seconds: 3), | |
| ), | |
| ); | |
| } | |
| } | |
| Future<void> _executeAction(Future<void> Function() action, String actionName) async { | |
| try { | |
| await action(); | |
| scaffoldMessenger.showSnackBar( | |
| SnackBar( | |
| content: Text("$actionName Successful"), | |
| duration: const Duration(seconds: 3), | |
| ), | |
| ); | |
| } on Exception catch (error) { | |
| scaffoldMessenger.showSnackBar( | |
| SnackBar( | |
| content: Text("$actionName Error: $error"), | |
| duration: const Duration(seconds: 3), | |
| ), | |
| ); | |
| } | |
| } |
muzzammilshahid
force-pushed
the
refactor-cleanups
branch
from
7e8a481 to
da33bdc
Compare
lib/screens/mobile/mobile_home.dart
Outdated
| routerResult.toggleSwitch(value: false); | ||
| } | ||
|
|
||
| Widget _buildTabWithDeleteButton(MapEntry<int, String> entry) { |
There was a problem hiding this comment.
Refactor to improve readability by using a more descriptive parameter.
- Widget _buildTabWithDeleteButton(MapEntry<int, String> entry)
+ Widget _buildTabWithDeleteButton({required int tabIndex, required String tabName})Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
Suggested change
| Widget _buildTabWithDeleteButton(MapEntry<int, String> entry) { | |
| Widget _buildTabWithDeleteButton({required int tabIndex, required String tabName}) { |
lib/screens/mobile/mobile_home.dart
Outdated
Comment on lines
288
to
311
| return Align( | ||
| alignment: Alignment.topLeft, | ||
| child: Padding( | ||
| padding: const EdgeInsets.only(top: 10), | ||
| child: Container( | ||
| margin: const EdgeInsets.only(left: 20, right: 20), | ||
| padding: const EdgeInsets.all(10), | ||
| decoration: BoxDecoration( | ||
| color: Colors.blue[50], | ||
| borderRadius: BorderRadius.circular(8), | ||
| ), | ||
| child: Text( | ||
| invocation, | ||
| style: TextStyle( | ||
| fontSize: 17, | ||
| fontWeight: FontWeight.w700, | ||
| color: blackColor, | ||
| ), | ||
| ), | ||
| ), | ||
| ), | ||
| ); | ||
| }).toList(), | ||
| ); | ||
| }, | ||
| ), | ||
| Consumer<EventProvider>( | ||
| builder: (context, eventResult, _) { | ||
| List<String> results = eventResult.events; | ||
| List<String> eventRslt = results.where((result) => result.startsWith("$index:")).toList(); | ||
| return Column( | ||
| crossAxisAlignment: CrossAxisAlignment.start, | ||
| children: eventRslt.map((event) { | ||
| return Align( | ||
| alignment: Alignment.topLeft, | ||
| child: Padding( | ||
| padding: const EdgeInsets.only(top: 10), | ||
| child: Container( | ||
| margin: const EdgeInsets.only(left: 20, right: 20), | ||
| padding: const EdgeInsets.all(10), | ||
| decoration: BoxDecoration( | ||
| color: Colors.blue[50], | ||
| borderRadius: BorderRadius.circular(8), | ||
| ), | ||
| child: Text( | ||
| event, | ||
| style: TextStyle( | ||
| fontSize: 17, | ||
| fontWeight: FontWeight.w700, | ||
| color: blackColor, | ||
| ), | ||
| ), | ||
| ), | ||
| ), | ||
| ); | ||
| }).toList(), | ||
| ); | ||
| }, | ||
| ), | ||
| Consumer<ResultProvider>( | ||
| builder: (context, callResult, _) { | ||
| List<String> results = callResult.results; | ||
| _tabData[index].callRslt = results.where((result) => result.startsWith("$index:")).toList(); | ||
| return Column( | ||
| crossAxisAlignment: CrossAxisAlignment.start, | ||
| children: _tabData[index].callRslt!.map((result) { | ||
| return Align( | ||
| alignment: Alignment.topLeft, | ||
| child: Padding( | ||
| padding: const EdgeInsets.only(top: 10), | ||
| child: Container( | ||
| margin: const EdgeInsets.only(left: 20, right: 20), | ||
| padding: const EdgeInsets.all(10), | ||
| decoration: BoxDecoration( | ||
| color: Colors.blue[50], | ||
| borderRadius: BorderRadius.circular(8), | ||
| ), | ||
| child: Text( | ||
| result, | ||
| style: TextStyle( | ||
| fontSize: 17, | ||
| fontWeight: FontWeight.w700, | ||
| color: blackColor, | ||
| ), | ||
| ), | ||
| ), | ||
| ), | ||
| ); | ||
| }).toList(), | ||
| ); | ||
| }, | ||
| ), | ||
|
|
||
| const SizedBox( | ||
| height: 20, | ||
| ), | ||
| _buildInvocationResults(index), | ||
| _buildEventResults(index), | ||
| _buildCallResults(index), | ||
| const SizedBox(height: 20), |
There was a problem hiding this comment.
Optimize the building of tab views by reducing redundancy.
- Widget _buildTab(MapEntry<int, String> entry) {
+ Widget _buildTab(int index, String tabContent) {
return SingleChildScrollView(
physics: const BouncingScrollPhysics(),
child: Column(
children: [
_buildTabActionDropdown(index),
const SizedBox(height: 20),
_buildTabSerializerDropdown(index),
const SizedBox(height: 20),
buildTopicProcedure(_tabData[index].topicProcedureController, _tabData[index].sendButtonText),
const SizedBox(height: 20),
buildArgs(_tabData[index].sendButtonText, _argsProviders[index]),
const SizedBox(height: 20),
buildKwargs(_tabData[index].sendButtonText, _kwargsProviders[index]),
const SizedBox(height: 20),
sendButton(_tabData[index].sendButtonText, index),
const SizedBox(height: 50),
resultText(_tabData[index].sendButtonText),
_buildInvocationResults(index),
_buildEventResults(index),
_buildCallResults(index),
const SizedBox(height: 20),
],
),
);
}Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
Suggested change
| Widget _buildTab(MapEntry<int, String> entry) { | |
| final index = entry.key; | |
| return SingleChildScrollView( | |
| physics: const BouncingScrollPhysics(), | |
| child: Column( | |
| children: [ | |
| Padding( | |
| padding: const EdgeInsets.symmetric(horizontal: 15), | |
| child: Container( | |
| padding: const EdgeInsets.symmetric(horizontal: 15), | |
| decoration: BoxDecoration( | |
| borderRadius: BorderRadius.circular(8), | |
| border: Border.all(color: Colors.grey), | |
| ), | |
| child: Row( | |
| children: [ | |
| SizedBox( | |
| width: 100, | |
| child: DropdownButton<String>( | |
| value: _tabData[index].selectedValue.isEmpty ? null : _tabData[index].selectedValue, | |
| hint: Text( | |
| "Actions", | |
| style: TextStyle(color: dropDownTextColor), | |
| ), | |
| items: <String>[ | |
| "Register", | |
| "Subscribe", | |
| "Call", | |
| "Publish", | |
| ].map((String value) { | |
| return DropdownMenuItem<String>( | |
| value: value, | |
| child: Text( | |
| value, | |
| style: TextStyle(color: dropDownTextColor), | |
| ), | |
| ); | |
| }).toList(), | |
| onChanged: (String? newValue) { | |
| setState(() { | |
| _tabData[index].selectedValue = newValue!; | |
| switch (newValue) { | |
| case "Subscribe": | |
| { | |
| _tabData[index].sendButtonText = "Subscribe"; | |
| break; | |
| } | |
| case "Register": | |
| { | |
| _tabData[index].sendButtonText = "Register"; | |
| break; | |
| } | |
| case "Call": | |
| { | |
| _tabData[index].sendButtonText = "Call"; | |
| break; | |
| } | |
| case "Publish": | |
| { | |
| _tabData[index].sendButtonText = "Publish"; | |
| break; | |
| } | |
| default: | |
| { | |
| _tabData[index].sendButtonText = "Send"; | |
| } | |
| } | |
| }); | |
| }, | |
| ), | |
| ), | |
| Container( | |
| height: 30, | |
| width: 1, | |
| color: Colors.grey, | |
| ), | |
| Expanded( | |
| child: TextFormField( | |
| controller: _tabData[index].linkController, | |
| decoration: const InputDecoration( | |
| hintText: "Enter URL or paste text", | |
| labelText: "Enter URL or paste text", | |
| border: InputBorder.none, | |
| contentPadding: EdgeInsets.all(10), | |
| ), | |
| ), | |
| ), | |
| ], | |
| ), | |
| ), | |
| ), | |
| const SizedBox( | |
| height: 20, | |
| ), | |
| Padding( | |
| padding: const EdgeInsets.symmetric(horizontal: 15), | |
| child: Row( | |
| children: [ | |
| Container( | |
| padding: const EdgeInsets.symmetric( | |
| horizontal: 10, | |
| ), | |
| decoration: BoxDecoration( | |
| border: Border.all(color: Colors.grey), | |
| borderRadius: BorderRadius.circular(8), | |
| ), | |
| child: DropdownButton<String>( | |
| value: _tabData[index].selectedSerializer.isEmpty ? null : _tabData[index].selectedSerializer, | |
| hint: const Text("Serializers"), | |
| items: <String>[ | |
| jsonSerializer, | |
| cborSerializer, | |
| msgPackSerializer, | |
| ].map((String value) { | |
| return DropdownMenuItem<String>( | |
| value: value, | |
| child: Text(value), | |
| ); | |
| }).toList(), | |
| onChanged: (String? newValue) { | |
| setState(() { | |
| _tabData[index].selectedSerializer = newValue!; | |
| }); | |
| }, | |
| ), | |
| ), | |
| const SizedBox( | |
| width: 10, | |
| ), | |
| Expanded( | |
| child: TextFormField( | |
| controller: _tabData[index].realmController, | |
| decoration: InputDecoration( | |
| hintText: "Enter realm here", | |
| labelText: "Enter realm here", | |
| border: OutlineInputBorder( | |
| borderRadius: BorderRadius.circular(8), | |
| ), | |
| contentPadding: const EdgeInsets.all(10), | |
| ), | |
| ), | |
| ), | |
| ], | |
| ), | |
| ), | |
| const SizedBox( | |
| height: 20, | |
| ), | |
| // Topic Procedure TextFormFields | |
| _buildTabActionDropdown(index), | |
| const SizedBox(height: 20), | |
| _buildTabSerializerDropdown(index), | |
| const SizedBox(height: 20), | |
| buildTopicProcedure(_tabData[index].topicProcedureController, _tabData[index].sendButtonText), | |
| const SizedBox(height: 20), | |
| // Args | |
| buildArgs(_tabData[index].sendButtonText, _argsProviders[index]), | |
| const SizedBox(height: 20), | |
| // K-Wargs | |
| buildKwargs(_tabData[index].sendButtonText, _kwargsProviders[index]), | |
| const SizedBox(height: 20), | |
| // Send Button | |
| sendButton(_tabData[index].sendButtonText, index), | |
| const SizedBox(height: 50), | |
| resultText(_tabData[index].sendButtonText), | |
| Consumer<InvocationProvider>( | |
| builder: (context, invocationResult, _) { | |
| List<String> results = invocationResult.invocations; | |
| List<String> invocationRslt = results.where((result) => result.startsWith("$index:")).toList(); | |
| return Column( | |
| crossAxisAlignment: CrossAxisAlignment.start, | |
| children: invocationRslt.map((invocation) { | |
| return Align( | |
| alignment: Alignment.topLeft, | |
| child: Padding( | |
| padding: const EdgeInsets.only(top: 10), | |
| child: Container( | |
| margin: const EdgeInsets.only(left: 20, right: 20), | |
| padding: const EdgeInsets.all(10), | |
| decoration: BoxDecoration( | |
| color: Colors.blue[50], | |
| borderRadius: BorderRadius.circular(8), | |
| ), | |
| child: Text( | |
| invocation, | |
| style: TextStyle( | |
| fontSize: 17, | |
| fontWeight: FontWeight.w700, | |
| color: blackColor, | |
| ), | |
| ), | |
| ), | |
| ), | |
| ); | |
| }).toList(), | |
| ); | |
| }, | |
| ), | |
| Consumer<EventProvider>( | |
| builder: (context, eventResult, _) { | |
| List<String> results = eventResult.events; | |
| List<String> eventRslt = results.where((result) => result.startsWith("$index:")).toList(); | |
| return Column( | |
| crossAxisAlignment: CrossAxisAlignment.start, | |
| children: eventRslt.map((event) { | |
| return Align( | |
| alignment: Alignment.topLeft, | |
| child: Padding( | |
| padding: const EdgeInsets.only(top: 10), | |
| child: Container( | |
| margin: const EdgeInsets.only(left: 20, right: 20), | |
| padding: const EdgeInsets.all(10), | |
| decoration: BoxDecoration( | |
| color: Colors.blue[50], | |
| borderRadius: BorderRadius.circular(8), | |
| ), | |
| child: Text( | |
| event, | |
| style: TextStyle( | |
| fontSize: 17, | |
| fontWeight: FontWeight.w700, | |
| color: blackColor, | |
| ), | |
| ), | |
| ), | |
| ), | |
| ); | |
| }).toList(), | |
| ); | |
| }, | |
| ), | |
| Consumer<ResultProvider>( | |
| builder: (context, callResult, _) { | |
| List<String> results = callResult.results; | |
| _tabData[index].callRslt = results.where((result) => result.startsWith("$index:")).toList(); | |
| return Column( | |
| crossAxisAlignment: CrossAxisAlignment.start, | |
| children: _tabData[index].callRslt!.map((result) { | |
| return Align( | |
| alignment: Alignment.topLeft, | |
| child: Padding( | |
| padding: const EdgeInsets.only(top: 10), | |
| child: Container( | |
| margin: const EdgeInsets.only(left: 20, right: 20), | |
| padding: const EdgeInsets.all(10), | |
| decoration: BoxDecoration( | |
| color: Colors.blue[50], | |
| borderRadius: BorderRadius.circular(8), | |
| ), | |
| child: Text( | |
| result, | |
| style: TextStyle( | |
| fontSize: 17, | |
| fontWeight: FontWeight.w700, | |
| color: blackColor, | |
| ), | |
| ), | |
| ), | |
| ), | |
| ); | |
| }).toList(), | |
| ); | |
| }, | |
| ), | |
| const SizedBox( | |
| height: 20, | |
| ), | |
| _buildInvocationResults(index), | |
| _buildEventResults(index), | |
| _buildCallResults(index), | |
| const SizedBox(height: 20), | |
| Widget _buildTab(int index, String tabContent) { | |
| return SingleChildScrollView( | |
| physics: const BouncingScrollPhysics(), | |
| child: Column( | |
| children: [ | |
| _buildTabActionDropdown(index), | |
| const SizedBox(height: 20), | |
| _buildTabSerializerDropdown(index), | |
| const SizedBox(height: 20), | |
| buildTopicProcedure(_tabData[index].topicProcedureController, _tabData[index].sendButtonText), | |
| const SizedBox(height: 20), | |
| buildArgs(_tabData[index].sendButtonText, _argsProviders[index]), | |
| const SizedBox(height: 20), | |
| buildKwargs(_tabData[index].sendButtonText, _kwargsProviders[index]), | |
| const SizedBox(height: 20), | |
| sendButton(_tabData[index].sendButtonText, index), | |
| const SizedBox(height: 50), | |
| resultText(_tabData[index].sendButtonText), | |
| _buildInvocationResults(index), | |
| _buildEventResults(index), | |
| _buildCallResults(index), | |
| const SizedBox(height: 20), | |
| ], | |
| ), | |
| ); | |
| } |
Comment on lines
+140
to
+142
| await _showRouterDialog(context, routerResult, scaffoldMessenger); | ||
| } else { | ||
| await showDialog( | ||
| context: context, | ||
| builder: (BuildContext context) { | ||
| return AlertDialog( | ||
| title: Text( | ||
| "Router Connection", | ||
| style: TextStyle( | ||
| fontWeight: FontWeight.w700, | ||
| color: homeAppBarTextColor, | ||
| fontSize: iconSize, | ||
| ), | ||
| ), | ||
| content: InkWell( | ||
| onTap: () { | ||
| routerProvider.serverRouter.close(); | ||
| routerResult.setServerStarted(started: false); | ||
| Navigator.of(context).pop(); | ||
| }, | ||
| child: Container( | ||
| height: 35, | ||
| width: MediaQuery.of(context).size.width, | ||
| alignment: Alignment.center, | ||
| decoration: BoxDecoration( | ||
| borderRadius: BorderRadius.circular(5), | ||
| gradient: LinearGradient( | ||
| colors: [ | ||
| blueAccentColor, | ||
| Colors.lightBlue, | ||
| ], | ||
| ), | ||
| ), | ||
| child: Text( | ||
| "Close", | ||
| style: TextStyle(color: whiteColor, fontSize: 18, fontWeight: FontWeight.bold), | ||
| ), | ||
| ), | ||
| ), | ||
| ); | ||
| }, | ||
| ); | ||
| routerResult.toggleSwitch(value: false); | ||
| await _showCloseRouterDialog(context, routerProvider, routerResult); |
There was a problem hiding this comment.
Tip
Codebase Verification
Ensure proper error handling in asynchronous operations.
The inspection of the surrounding code for await statements in lib/screens/mobile/mobile_home.dart and lib/screens/mobile/router_dialogbox.dart reveals that some asynchronous operations are already wrapped in try and catch blocks, ensuring proper error handling. However, there are instances where await statements are not enclosed in error handling constructs.
Instances without proper error handling:
lib/screens/mobile/mobile_home.dartawait _showRouterDialog(context, routerResult, scaffoldMessenger);await _showCloseRouterDialog(context, routerProvider, routerResult);await showDialog(...)await session.publish(...)await session?.unregister(reg);await session?.unsubscribe(sub);await session.register(...)await session.subscribe(...)await session.call(...)
Instances with proper error handling:
lib/screens/mobile/mobile_home.dartawait action();(wrapped intryandcatch)await connect(...)(wrapped intryandcatch)
lib/screens/mobile/router_dialogbox.dartawait Navigator.pushReplacement(...)(wrapped intryandcatch)
Recommendations:
- Wrap all asynchronous operations in
tryandcatchblocks to ensure proper error handling. - Review the identified instances and add error handling where missing.
Code Locations:
lib/screens/mobile/mobile_home.dartlib/screens/mobile/router_dialogbox.dart
Analysis chain
Ensure proper error handling in asynchronous operations.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify proper error handling in asynchronous operations related to router dialogs.
# Test: Search for error handling patterns in asynchronous methods.
rg --type dart 'try {.*await.*} catch'
Length of output: 149
Script:
#!/bin/bash
# Description: Verify proper error handling in asynchronous operations related to router dialogs.
# Test: Search for error handling patterns in asynchronous methods.
rg --type dart 'try\s*{[^}]*await[^}]*}\s*catch'
Length of output: 171
Script:
#!/bin/bash
# Description: Verify proper error handling in asynchronous operations related to router dialogs.
# Test: Search for error handling patterns in asynchronous methods.
rg --type dart 'try\s*{[^}]*await[^}]*}\s*catch\s*{'
Length of output: 179
Script:
#!/bin/bash
# Description: Verify proper error handling in asynchronous operations related to router dialogs.
# Test: Search for await statements in Dart files.
rg --type dart 'await'
Length of output: 1650
Script:
#!/bin/bash
# Description: Extract lines around await statements for manual inspection of error handling.
# Extract lines around await statements in lib/screens/mobile/mobile_home.dart
rg --type dart --context 5 'await' lib/screens/mobile/mobile_home.dart
# Extract lines around await statements in lib/screens/mobile/router_dialogbox.dart
rg --type dart --context 5 'await' lib/screens/mobile/router_dialogbox.dart
Length of output: 6200
There was a problem hiding this comment.
@shakeebkhan66 please take care of it in follow up.
There was a problem hiding this comment.
Seems like the humans are having a chat. I'll hop back into my burrow for now. If you need me again, just tag @coderabbitai in a new comment, and I'll come hopping out!
muzzammilshahid
force-pushed
the
refactor-cleanups
branch
from
da33bdc to
b14bd1d
Compare
Mahad-10
approved these changes
Jun 1, 2024
muzzammilshahid
force-pushed
the
refactor-cleanups
branch
from
b14bd1d to
5a2c17d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.