initial UI for mobile #3
Conversation
shakeebkhan66
force-pushed
the
user-interface
branch
from
d42b5ef to
6f42e9e
Compare
WalkthroughThe recent updates bring a significant restructuring to the Flutter application. Key changes include integrating Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Out of diff range and nitpick comments (4)
lib/screens/mobile/mobile_home.dart (2)
69-116: Thebuildmethod efficiently constructs the UI with dynamic tabs. Consider adding comments for better readability and maintenance.
119-579: The helper methods_buildTabWithDeleteButtonand_buildTabare well-implemented. Consider using more descriptive variable names for better code clarity.lib/screens/tablet/tablet_home.dart (2)
69-116: Thebuildmethod efficiently constructs the UI with dynamic tabs for tablet devices. Consider adding comments for better readability and maintenance.
119-579: The helper methods_buildTabWithDeleteButtonand_buildTabare well-implemented. Consider using more descriptive variable names for better code clarity.
Review Details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (12)
- lib/Providers/args_provider.dart (1 hunks)
- lib/Providers/kwargs_provider.dart (1 hunks)
- lib/constants/my_constant.dart (1 hunks)
- lib/main.dart (2 hunks)
- lib/responsive/responsive_layout.dart (1 hunks)
- lib/screens/desktop/desktop_home.dart (1 hunks)
- lib/screens/mobile/mobile_home.dart (1 hunks)
- lib/screens/tablet/tablet_home.dart (1 hunks)
- lib/utils/args_screen.dart (1 hunks)
- lib/utils/kwargs_screen.dart (1 hunks)
- pubspec.yaml (1 hunks)
- test/widget_test.dart (1 hunks)
Files skipped from review due to trivial changes (2)
- lib/constants/my_constant.dart
- test/widget_test.dart
Additional comments not posted (23)
lib/screens/desktop/desktop_home.dart (2)
4-4: Constructor usessuper.keyappropriately, adhering to Flutter best practices.
7-11: The build method correctly sets up a basic UI scaffold with a green accent background color.lib/Providers/kwargs_provider.dart (3)
4-6: The data structure_tableDatais appropriately set up for managing dynamic key-value pairs.
10-13: TheaddRowmethod correctly implements reactive state management by adding a row and notifying listeners.
15-18: TheremoveRowmethod is implemented correctly, ensuring reactive updates by removing a row and notifying listeners.lib/Providers/args_provider.dart (4)
4-4: Initialization ofcontrollerswith oneTextEditingControlleris appropriate for dynamic text field management.
6-9: TheaddControllermethod correctly manages the addition of controllers dynamically and notifies listeners for UI updates.
11-14: TheremoveControllermethod is implemented correctly, ensuring reactive updates by removing a controller and notifying listeners.
16-22: Thedisposemethod is well-implemented, ensuring all controllers are disposed of properly to avoid memory leaks.lib/responsive/responsive_layout.dart (2)
4-9: Constructor initializes properties for mobile, tablet, and desktop layouts appropriately, supporting responsive design.
14-27: The build method effectively implements responsive design by usingLayoutBuilderto select the appropriate layout based on screen width.lib/main.dart (2)
19-23: The setup ofMultiProvidercorrectly manages state across the app by providing instances ofArgsProviderandTableDataProvider.
24-32:MaterialAppis configured appropriately with modern settings (useMaterial3) and a responsive layout, enhancing the user experience.lib/utils/args_screen.dart (1)
6-55: TheArgsTextFormFieldswidget effectively uses the provider pattern withConsumerto dynamically generate text form fields based on the state inArgsProvider.pubspec.yaml (1)
34-40: The addition of new dependencies (dynamic_tabbar,provider,wampproto,xconn) is appropriate for supporting the new features introduced in the PR.lib/utils/kwargs_screen.dart (2)
7-22: TheDynamicKeyValuePairswidget correctly implements dynamic UI updates using the provider pattern withConsumerto interact withTableDataProvider.
25-147: TheTableWidgetis well-implemented, managing a dynamic table with editable cells and delete functionality, using effective state management for reactive updates.lib/screens/mobile/mobile_home.dart (3)
9-13: TheTabDataclass is well-defined and encapsulates the data for each tab effectively.
15-20: The structure ofMobileHomeScaffoldis correctly implemented as a stateful widget.
22-67: Ensure that theTabControlleris properly disposed to prevent memory leaks. The implementation here is correct.lib/screens/tablet/tablet_home.dart (3)
9-13: TheTabDataclass is consistently used across different device layouts, which is good for maintainability.
15-20: The structure ofTabletHomeScaffoldis correctly implemented as a stateful widget for tablet devices.
22-67: Ensure that theTabControlleris properly disposed to prevent memory leaks. The implementation here is correct and mirrors the mobile version.
shakeebkhan66
force-pushed
the
user-interface
branch
from
6f42e9e to
99d89fc
Compare
There was a problem hiding this comment.
Actionable comments posted: 3
Review Details
Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Files selected for processing (12)
- lib/Providers/args_provider.dart (1 hunks)
- lib/Providers/kwargs_provider.dart (1 hunks)
- lib/constants/my_constant.dart (1 hunks)
- lib/main.dart (2 hunks)
- lib/responsive/responsive_layout.dart (1 hunks)
- lib/screens/desktop/desktop_home.dart (1 hunks)
- lib/screens/mobile/mobile_home.dart (1 hunks)
- lib/screens/tablet/tablet_home.dart (1 hunks)
- lib/utils/args_screen.dart (1 hunks)
- lib/utils/kwargs_screen.dart (1 hunks)
- pubspec.yaml (1 hunks)
- test/widget_test.dart (1 hunks)
Files skipped from review as they are similar to previous changes (10)
- lib/Providers/args_provider.dart
- lib/Providers/kwargs_provider.dart
- lib/constants/my_constant.dart
- lib/main.dart
- lib/responsive/responsive_layout.dart
- lib/screens/desktop/desktop_home.dart
- lib/screens/tablet/tablet_home.dart
- lib/utils/args_screen.dart
- pubspec.yaml
- test/widget_test.dart
Additional comments not posted (2)
lib/utils/kwargs_screen.dart (1)
7-22: Implementation ofDynamicKeyValuePairslooks good and follows best practices for usingConsumerin Flutter.lib/screens/mobile/mobile_home.dart (1)
69-116: The build method implementation inMobileHomeScaffoldis well-structured and effectively handles conditional rendering based on the tab presence. Good use ofPreferredSizefor theTabBar.
lib/utils/kwargs_screen.dart
Outdated
| TableRow _buildTableRow( | ||
| Map<String, String> rowData, | ||
| int index, | ||
| TableDataProvider tableProvider, | ||
| ) { | ||
| return TableRow( | ||
| children: [ | ||
| _buildTableCell( | ||
| TextFormField( | ||
| initialValue: rowData["key"], | ||
| onChanged: (newValue) { | ||
| setState(() { | ||
| rowData["key"] = newValue; | ||
| }); | ||
| }, | ||
| decoration: const InputDecoration( | ||
| border: InputBorder.none, | ||
| contentPadding: EdgeInsets.all(8), | ||
| ), | ||
| ), | ||
| ), | ||
| _buildTableCell( | ||
| TextFormField( | ||
| initialValue: rowData["value"], | ||
| onChanged: (newValue) { | ||
| setState(() { | ||
| rowData["value"] = newValue; | ||
| }); | ||
| }, | ||
| decoration: const InputDecoration( | ||
| border: InputBorder.none, | ||
| contentPadding: EdgeInsets.all(8), | ||
| ), | ||
| ), | ||
| ), | ||
| _buildTableCell( | ||
| IconButton( | ||
| icon: Icon( | ||
| Icons.delete, | ||
| color: closeIconColor, | ||
| ), | ||
| onPressed: () { | ||
| setState(() { | ||
| tableProvider.removeRow(index); | ||
| }); | ||
| }, | ||
| ), | ||
| ), | ||
| ], | ||
| ); | ||
| } |
There was a problem hiding this comment.
Consider optimizing the row deletion process by not recreating the TabController every time a row is deleted. This could improve performance, especially with a large number of rows.
lib/screens/mobile/mobile_home.dart
Outdated
| void _addTab() { | ||
| setState(() { | ||
| int newIndex = _tabNames.length + 1; | ||
| _tabNames.add("Tab $newIndex"); | ||
| _tabContents.add("Content for Tab $newIndex"); | ||
| _tabData.add(TabData()); | ||
| _tabController = TabController(length: _tabNames.length, vsync: this); | ||
| _tabController.addListener(_handleTabSelection); | ||
| }); |
There was a problem hiding this comment.
Optimize tab addition by reusing the existing TabController if possible, instead of recreating it every time a new tab is added. This could enhance performance and reduce resource usage.
lib/screens/mobile/mobile_home.dart
Outdated
| void _removeTab(int index) { | ||
| setState(() { | ||
| _tabNames.removeAt(index); | ||
| _tabContents.removeAt(index); | ||
| _tabData.removeAt(index); | ||
| _tabController = TabController(length: _tabNames.length, vsync: this); | ||
| _tabController.addListener(_handleTabSelection); | ||
| }); |
There was a problem hiding this comment.
Optimize tab removal by reusing the existing TabController if possible, instead of recreating it every time a tab is removed. This could enhance performance and reduce resource usage.
There was a problem hiding this comment.
Actionable comments posted: 2
Review Details
Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Files selected for processing (3)
- lib/main.dart (2 hunks)
- lib/screens/mobile/mobile_home.dart (1 hunks)
- lib/utils/kwargs_screen.dart (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- lib/screens/mobile/mobile_home.dart
Additional comments not posted (3)
lib/main.dart (1)
20-34: Ensure that the providers added match the application's state management needs.This setup introduces
ArgsProvider,TableDataProvider, andProtocolsCallingProvideras global state managers, which should facilitate better state handling across different parts of the application.lib/utils/kwargs_screen.dart (2)
12-22: Ensure proper usage of theConsumerwidget for state management.The
Consumerwidget is correctly used here to listen to changes inTableDataProvider. This setup ensures that the UI updates reactively when the data changes.
39-90: Optimize the row deletion process in the table widget.The previous comment about optimizing the row deletion process by not recreating the
TabControllerevery time a row is deleted is still valid. Consider implementing this optimization to enhance performance.
lib/main.dart
Outdated
| debugShowCheckedModeBanner: false, | ||
| theme: ThemeData( | ||
| useMaterial3: true, | ||
| ), | ||
| home: const ResponsiveLayout( | ||
| mobileScaffold: MobileHomeScaffold(), | ||
| tabletScaffold: TabletHomeScaffold(), | ||
| desktopScaffold: DesktopHomeScaffold(), |
There was a problem hiding this comment.
Review the MaterialApp configuration for potential improvements.
Consider setting a global theme for the app to ensure consistency across all screens. For example, you might want to define a primary color or font style that aligns with your brand.
ThemeData(
+ primarySwatch: Colors.blue,
+ fontFamily: 'Arial',
useMaterial3: true,
),Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| debugShowCheckedModeBanner: false, | |
| theme: ThemeData( | |
| useMaterial3: true, | |
| ), | |
| home: const ResponsiveLayout( | |
| mobileScaffold: MobileHomeScaffold(), | |
| tabletScaffold: TabletHomeScaffold(), | |
| desktopScaffold: DesktopHomeScaffold(), | |
| debugShowCheckedModeBanner: false, | |
| theme: ThemeData( | |
| primarySwatch: Colors.blue, | |
| fontFamily: 'Arial', | |
| useMaterial3: true, | |
| ), | |
| home: const ResponsiveLayout( | |
| mobileScaffold: MobileHomeScaffold(), | |
| tabletScaffold: TabletHomeScaffold(), | |
| desktopScaffold: DesktopHomeScaffold(), |
lib/utils/kwargs_screen.dart
Outdated
| setState(() { | ||
| rowData["key"] = newValue; | ||
| }); | ||
| }, | ||
| decoration: const InputDecoration( | ||
| border: InputBorder.none, | ||
| contentPadding: EdgeInsets.all(8), | ||
| ), | ||
| ), | ||
| ), | ||
| _buildTableCell( | ||
| TextFormField( | ||
| initialValue: rowData["value"], | ||
| onChanged: (newValue) { | ||
| setState(() { | ||
| rowData["value"] = newValue; | ||
| }); |
There was a problem hiding this comment.
Refactor to improve the handling of state changes.
Consider using a more efficient way to handle state updates in text fields to avoid unnecessary rebuilds. For example, you could use a form key or separate state management for form fields.
- setState(() {
- rowData["key"] = newValue;
- });
+ rowData["key"] = newValue;
+ if (tableProvider.hasListeners) {
+ tableProvider.notifyListeners();
+ }
lib/screens/mobile/mobile_home.dart
Outdated
| // void _addTab() { | ||
| // setState(() { | ||
| // int newIndex = _tabNames.length + 1; | ||
| // _tabNames.add("Tab $newIndex"); | ||
| // _tabContents.add("Content for Tab $newIndex"); | ||
| // _tabData.add(TabData()); | ||
| // _tabController = TabController(length: _tabNames.length, vsync: this); | ||
| // _tabController.addListener(_handleTabSelection); | ||
| // }); | ||
| // } | ||
|
|
||
| // void _removeTab(int index) { | ||
| // setState(() { | ||
| // _tabNames.removeAt(index); | ||
| // _tabContents.removeAt(index); | ||
| // _tabData.removeAt(index); | ||
| // _tabController = TabController(length: _tabNames.length, vsync: this); | ||
| // _tabController.addListener(_handleTabSelection); | ||
| // }); | ||
| // } |
There was a problem hiding this comment.
| // void _addTab() { | |
| // setState(() { | |
| // int newIndex = _tabNames.length + 1; | |
| // _tabNames.add("Tab $newIndex"); | |
| // _tabContents.add("Content for Tab $newIndex"); | |
| // _tabData.add(TabData()); | |
| // _tabController = TabController(length: _tabNames.length, vsync: this); | |
| // _tabController.addListener(_handleTabSelection); | |
| // }); | |
| // } | |
| // void _removeTab(int index) { | |
| // setState(() { | |
| // _tabNames.removeAt(index); | |
| // _tabContents.removeAt(index); | |
| // _tabData.removeAt(index); | |
| // _tabController = TabController(length: _tabNames.length, vsync: this); | |
| // _tabController.addListener(_handleTabSelection); | |
| // }); | |
| // } |
lib/screens/mobile/mobile_home.dart
Outdated
| } | ||
|
|
||
| Widget _buildTab(int index) { | ||
| // var provider = Provider.of<ProtocolsCallingProvider>(context, listen: false); |
There was a problem hiding this comment.
| // var provider = Provider.of<ProtocolsCallingProvider>(context, listen: false); |
lib/screens/mobile/mobile_home.dart
Outdated
| if (newValue == "Subscribe") { | ||
| _tabData[index].sendButtonText = "Subscribe"; | ||
| } else if (newValue == "Register") { | ||
| _tabData[index].sendButtonText = "Register"; | ||
| } else if (newValue == "Call") { | ||
| _tabData[index].sendButtonText = "Call"; | ||
| } else if (newValue == "Publish") { | ||
| _tabData[index].sendButtonText = "Publish"; | ||
| } else { | ||
| _tabData[index].sendButtonText = "Send"; | ||
| } |
lib/screens/mobile/mobile_home.dart
Outdated
| if (_tabData[index].sendButtonText == "Publish") ...[ | ||
| Padding( | ||
| padding: const EdgeInsets.symmetric(horizontal: 15), | ||
| child: TextFormField( | ||
| decoration: InputDecoration( | ||
| hintText: "Enter topic here", | ||
| labelText: "Enter topic here", | ||
| border: OutlineInputBorder( | ||
| borderRadius: BorderRadius.circular(8), | ||
| ), | ||
| contentPadding: const EdgeInsets.all(10), | ||
| ), | ||
| ), | ||
| ), | ||
| ] else if (_tabData[index].sendButtonText == "Call") ...[ | ||
| Padding( | ||
| padding: const EdgeInsets.symmetric(horizontal: 15), | ||
| child: TextFormField( | ||
| decoration: InputDecoration( | ||
| hintText: "Enter procedure here", | ||
| labelText: "Enter procedure here", | ||
| border: OutlineInputBorder( | ||
| borderRadius: BorderRadius.circular(8), | ||
| ), | ||
| contentPadding: const EdgeInsets.all(10), | ||
| ), | ||
| ), | ||
| ), | ||
| ] else if (_tabData[index].sendButtonText == "Register") ...[ | ||
| Padding( | ||
| padding: const EdgeInsets.symmetric(horizontal: 15), | ||
| child: TextFormField( | ||
| decoration: InputDecoration( | ||
| hintText: "Enter procedure here", | ||
| labelText: "Enter procedure here", | ||
| border: OutlineInputBorder( | ||
| borderRadius: BorderRadius.circular(8), | ||
| ), | ||
| contentPadding: const EdgeInsets.all(10), | ||
| ), | ||
| ), | ||
| ), | ||
| ] else if (_tabData[index].sendButtonText == "Subscribe") ...[ | ||
| Padding( | ||
| padding: const EdgeInsets.symmetric(horizontal: 15), | ||
| child: TextFormField( | ||
| decoration: InputDecoration( | ||
| hintText: "Enter topic here", | ||
| labelText: "Enter topic here", | ||
| border: OutlineInputBorder( | ||
| borderRadius: BorderRadius.circular(8), | ||
| ), | ||
| contentPadding: const EdgeInsets.all(10), | ||
| ), | ||
| ), | ||
| ), | ||
| ] else ...[ | ||
| Container(), | ||
| ], |
lib/screens/tablet/tablet_home.dart
Outdated
| _tabController.addListener(_handleTabSelection); | ||
| } | ||
|
|
||
| // TODO HANDLE TABS SELECTION |
There was a problem hiding this comment.
| // TODO HANDLE TABS SELECTION |
lib/screens/tablet/tablet_home.dart
Outdated
| _tabData[index].selectedValue = newValue!; | ||
| if (newValue == "Subscribe") { | ||
| _tabData[index].sendButtonText = "Subscribe"; | ||
| } else if (newValue == "Register") { | ||
| _tabData[index].sendButtonText = "Register"; | ||
| } else if (newValue == "Call") { | ||
| _tabData[index].sendButtonText = "Call"; | ||
| } else if (newValue == "Publish") { | ||
| _tabData[index].sendButtonText = "Publish"; | ||
| } else { | ||
| _tabData[index].sendButtonText = "Send"; | ||
| } | ||
| }); |
lib/constants/my_constant.dart
Outdated
| @@ -0,0 +1,15 @@ | |||
| import "package:flutter/material.dart"; | |||
There was a problem hiding this comment.
file name should be constants
| if (constraints.maxWidth < 500) { | ||
| return mobileScaffold; | ||
| } else if (constraints.maxWidth < 1100) { | ||
| return tabletScaffold; | ||
| } else { | ||
| return desktopScaffold; |
There was a problem hiding this comment.
Is there any other better way to do this? This seems kind of hackish.
lib/Providers/kwargs_provider.dart
Outdated
| @@ -0,0 +1,19 @@ | |||
| import "package:flutter/cupertino.dart"; | |||
|
|
|||
| class TableDataProvider extends ChangeNotifier { | |||
There was a problem hiding this comment.
| class TableDataProvider extends ChangeNotifier { | |
| class KwargsProvider extends ChangeNotifier { |
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Files selected for processing (7)
- lib/Providers/kwargs_provider.dart (1 hunks)
- lib/constants.dart (1 hunks)
- lib/main.dart (2 hunks)
- lib/screens/mobile/mobile_home.dart (1 hunks)
- lib/utils/args_screen.dart (1 hunks)
- lib/utils/kwargs_screen.dart (1 hunks)
- lib/utils/tab_data_class.dart (1 hunks)
Files skipped from review due to trivial changes (1)
- lib/constants.dart
Files skipped from review as they are similar to previous changes (3)
- lib/Providers/kwargs_provider.dart
- lib/screens/mobile/mobile_home.dart
- lib/utils/args_screen.dart
Additional comments not posted (4)
lib/utils/tab_data_class.dart (1)
1-5: TheTabDataclass is well-defined and aligns with the PR's objectives for managing tab-specific data.lib/main.dart (1)
17-32: The restructuring of theMyAppclass to useMultiProviderfor state management is a significant improvement. The responsive layout settings and theme configuration are well-implemented.lib/utils/kwargs_screen.dart (2)
6-32: The implementation ofDynamicKeyValuePairsusingConsumerfor reactive updates is efficient and aligns well with the state management strategy described in the PR.
35-151: TheTableWidgetand its state management handle dynamic row operations effectively. The improvements in handling state changes in text fields, as previously suggested, have been well implemented.
There was a problem hiding this comment.
Actionable comments posted: 1
Review Details
Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Files selected for processing (4)
- lib/screens/mobile/mobile_home.dart (1 hunks)
- lib/utils/args_screen.dart (1 hunks)
- lib/utils/kwargs_screen.dart (1 hunks)
- lib/utils/tab_data_class.dart (1 hunks)
Files skipped from review as they are similar to previous changes (2)
- lib/utils/args_screen.dart
- lib/utils/tab_data_class.dart
Additional comments not posted (3)
lib/utils/kwargs_screen.dart (2)
6-32: Implementation ofDynamicKeyValuePairslooks good and follows best practices for usingConsumerin provider pattern.
35-150: The implementation ofTableWidgetand its state management is well-structured and modular. Good use of stateful widget to manage dynamic content.lib/screens/mobile/mobile_home.dart (1)
70-117: The overall structure and functionality of theMobileHomeScaffoldbuild method are well-implemented, providing a dynamic and responsive UI for mobile.
| void _addTab() { | ||
| setState(() { | ||
| int newIndex = _tabNames.length + 1; | ||
| _tabNames.add("Tab $newIndex"); | ||
| _tabContents.add("Content for Tab $newIndex"); | ||
| _tabData.add(TabData()); | ||
| if (_tabController.length != _tabNames.length) { | ||
| _tabController = TabController(length: _tabNames.length, vsync: this); | ||
| _tabController.addListener(_handleTabSelection); | ||
| } | ||
| }); | ||
| } | ||
|
|
||
| void _removeTab(int index) { | ||
| setState(() { | ||
| _tabNames.removeAt(index); | ||
| _tabContents.removeAt(index); | ||
| _tabData[index].disposeControllers(); | ||
| _tabData.removeAt(index); | ||
|
|
||
| if (_tabController.length != _tabNames.length) { | ||
| _tabController = TabController(length: _tabNames.length, vsync: this); | ||
| _tabController.addListener(_handleTabSelection); | ||
| } | ||
| }); | ||
| } |
There was a problem hiding this comment.
Consider optimizing tab management by reusing the existing TabController instead of recreating it every time a tab is added or removed. This could enhance performance and reduce resource usage.
- _tabController = TabController(length: _tabNames.length, vsync: this);
+ if (_tabController.length != _tabNames.length) {
+ _tabController.dispose();
+ _tabController = TabController(length: _tabNames.length, vsync: this);
+ }Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| void _addTab() { | |
| setState(() { | |
| int newIndex = _tabNames.length + 1; | |
| _tabNames.add("Tab $newIndex"); | |
| _tabContents.add("Content for Tab $newIndex"); | |
| _tabData.add(TabData()); | |
| if (_tabController.length != _tabNames.length) { | |
| _tabController = TabController(length: _tabNames.length, vsync: this); | |
| _tabController.addListener(_handleTabSelection); | |
| } | |
| }); | |
| } | |
| void _removeTab(int index) { | |
| setState(() { | |
| _tabNames.removeAt(index); | |
| _tabContents.removeAt(index); | |
| _tabData[index].disposeControllers(); | |
| _tabData.removeAt(index); | |
| if (_tabController.length != _tabNames.length) { | |
| _tabController = TabController(length: _tabNames.length, vsync: this); | |
| _tabController.addListener(_handleTabSelection); | |
| } | |
| }); | |
| } | |
| void _addTab() { | |
| setState(() { | |
| int newIndex = _tabNames.length + 1; | |
| _tabNames.add("Tab $newIndex"); | |
| _tabContents.add("Content for Tab $newIndex"); | |
| _tabData.add(TabData()); | |
| if (_tabController.length != _tabNames.length) { | |
| _tabController.dispose(); | |
| _tabController = TabController(length: _tabNames.length, vsync: this); | |
| _tabController.addListener(_handleTabSelection); | |
| } | |
| }); | |
| } | |
| void _removeTab(int index) { | |
| setState(() { | |
| _tabNames.removeAt(index); | |
| _tabContents.removeAt(index); | |
| _tabData[index].disposeControllers(); | |
| _tabData.removeAt(index); | |
| if (_tabController.length != _tabNames.length) { | |
| _tabController.dispose(); | |
| _tabController = TabController(length: _tabNames.length, vsync: this); | |
| _tabController.addListener(_handleTabSelection); | |
| } | |
| }); | |
| } |
Summary by CodeRabbit
New Features
MultiProviderandChangeNotifierProvider.UI Enhancements
ResponsiveLayout.State Management