Returns the number of allocated clusters in a Qcow #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Last commit: 9207abe "fix(linstor): check if resource is tiebreaker (#62)" Signed-off-by: Ronan Abhamon <[email protected]>
gthvn1
force-pushed
the
gtn-get-allocated-clusters
branch
2 times, most recently
from
8259021 to
303c6b0
Compare
|
I will probably put functions into a class and pass the filename during the init(). The init will update a header, L1 table and L2 table. So we won't pass the file and header every time and the Qcow file will be hold only during the init. |
stormi
reviewed
Nov 4, 2024
Ok noted 👍 . I took the default branch presented on the github page. But in fact it doesn't matter a lot because we will only took the class to add it to the future qcowutil.py file. So this PR probably won't be merged as is. |
gthvn1
force-pushed
the
gtn-get-allocated-clusters
branch
8 times, most recently
from
248cbc5 to
7254eea
Compare
gthvn1
force-pushed
the
gtn-get-allocated-clusters
branch
3 times, most recently
from
7b63087 to
6febcd4
Compare
This script can returns:
- the number of allocated clusters in a Qcow file.
- the number of newly allocated clusters in a Qcow file
compared to a reference one (like the backing file).
- it can erase all data and set clusters as unallocated
- it can set/unset/get the hidden property.
- for now it creates the custom header if not found but it can easily
be changed. It also moves the backing file name because when a
snapshot is created the hidden custom header is ignored so we need
to make space to crate it again.
NOTE: This script is a POC to validate that all helpers from vhd util
are also doable with qcow file. It will be used in another file.
Signed-off-by: Guillaume <[email protected]>
gthvn1
force-pushed
the
gtn-get-allocated-clusters
branch
from
6febcd4 to
881b48a
Compare
gthvn1
commented
Dec 4, 2024
| with open(self.filename, "rb+") as qcow2_file: | ||
| if self.header["version"] == 3: | ||
| qcow2_file.seek(100) # 100 is the offset of header_length | ||
| header_length = int.from_bytes(qcow2_file.read(4)) |
There was a problem hiding this comment.
It looks like we need to add the endianess: header_length = int.from_bytes(qcow2_file.read(4), 'big')
| custom_data_offset = 0 | ||
|
|
||
| while True: | ||
| ext_type = int.from_bytes(qcow2_file.read(4)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This script returns the number of allocated clusters in a Qcow file.
We probably won't use it like this but more probably as a library for the next qcow2util implementation.
I opened it because it is easier to discuss on a PR and like that we keep a backup while waiting to see what we do with it...