This repository has been archived by the owner on Jan 4, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 56
Import of Biohazard's work #74
Open
LalitMaganti
wants to merge
37
commits into
master
Choose a base branch
from
biohazard-import-staging
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed hardcoded string
* Material Design specifically states that in this usecase, dividers are unecessary distractions from the important content. * Removing the divider reduces the noise and makes it look better too IMHO
* also remove instances of padding/margins not conforming to keyline * also remove unused layouts
* reduce elevation so that shadow is smaller - matches the look of G+ * move quote and multiquote to right of posts - matches the look of G+
* play around with margins * make thread dates look nice again
@tilal6991 I'm wondering what the progress is on this pull request, would love to have these changes merged in! |
I was waiting for @BioHaZard1 to comment but then totally forgot about this stuff. It should still work TBH. |
Yeah sorry about that, completely forgot to comment. I think I've fixed everything you wanted done before the merge though. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an import of the excellent work done by @BioHaZard1 on materializing various parts of the app.
My opinion on the changes and this PR:
The Good:
The Neutral:
The Not So Good
Thanks again for the awesome work BioHaZard!
Tagging: @rwestergren, @ddrager