Enable concurrenct access to SchemaLoader #323
Conversation
|
@xeipuuv Hi there 👋🏼 -- I noticed there hasn't been a commit in the last 3 years. Let me know if this library is still maintained and if this change is acceptable to you. Thank you! |
| func (spd *schemaPoolDocuments) Load(key string) (*schemaPoolDocument, bool) { | ||
| val, ok := spd.mp.Load(key) |
There was a problem hiding this comment.
tbh, I wonder if the added complexity of using a sync.Map is needed for this use-case. sync.Map (by itself) does not have type-safety, so requires all the extra boilerplating in this file, and while sync.Map can perform better, in many situations it may actually be slower (unless high concurrency, large number of cores); https://medium.com/@deckarep/the-new-kid-in-town-gos-sync-map-de24a6bf7c2c
|
opened #324 as a possible alternative; let me know what you think 😅 |
|
/cc @johandorland PTAL |
|
@thaJeztah It might be fun to benchmark the two alternatives in different scenarios. But I'm definitely glad with either solutions if one can get merged upstream :) |
Adds a type-safe wrapper for the standard library's
sync.Mapas it fits the usecase of how gojsonschema uses its internal pool: write once, read many.Fixes xeipuuv/gojsonreference#9