-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/separate rects button #133
Open
dukobpa3
wants to merge
15
commits into
xemle:master
Choose a base branch
from
dukobpa3:feature/separate_rects_button
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rearrange blocks in details view, some polishing
found little bug |
@dukobpa3 what are the status of this PR? Are you still working on it? |
I see you've cherrypicked it already. But the still bug which I've not fixed. This button shown on videos also. I wanted to show only if relevant. |
Cool. Thank you for the update and your contribution. I will have a look in the next days. The code looks fine so far. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added buttons to on/off objects/faces rects on photos.
Now we can hide rects while details opened and show them while details closed
Why:
• on mobile not so comfortable to navigate with opened info panel so I prefer to hide it. But I want to be able to click on objects
• on desktop info panel mostly opened but I want to hide rects and see clean pictures because I can click on tags in panel
And also changed couple icons in the main menu