Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/separate rects button #133

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

dukobpa3
Copy link

@dukobpa3 dukobpa3 commented Apr 10, 2024

Added buttons to on/off objects/faces rects on photos.
Now we can hide rects while details opened and show them while details closed

Why:
• on mobile not so comfortable to navigate with opened info panel so I prefer to hide it. But I want to be able to click on objects
• on desktop info panel mostly opened but I want to hide rects and see clean pictures because I can click on tags in panel

image

And also changed couple icons in the main menu

@dukobpa3
Copy link
Author

found little bug
it shows button on videos also

@dukobpa3 dukobpa3 marked this pull request as draft April 14, 2024 18:23
@xemle
Copy link
Owner

xemle commented Sep 13, 2024

@dukobpa3 what are the status of this PR? Are you still working on it?

@dukobpa3
Copy link
Author

I see you've cherrypicked it already. But the still bug which I've not fixed. This button shown on videos also. I wanted to show only if relevant.

@dukobpa3 dukobpa3 marked this pull request as ready for review September 25, 2024 11:18
@dukobpa3
Copy link
Author

@xemle
Fixed.
Button will be shown only if there is any rect
Ready to merge

And also updated icons from this one: #132

@xemle
Copy link
Owner

xemle commented Sep 28, 2024

Cool. Thank you for the update and your contribution. I will have a look in the next days. The code looks fine so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants