CA-358870: Backport the fixes from #67 to filter the XAPI ClusterD DB for XS8, Yangtze #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'token' is an API token that is used to authenticate all API requests to the xapi-clusterd daemon. - Apply the fix originally developed and tested by Edwin. - Update the tests: - Ensure that the fix works and keeps working across future changes. Co-authored-by: Bernhard Kaindl <[email protected]> Signed-off-by: Edwin Török <[email protected]> (cherry picked from commit 9a64b44)
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release/xs8 #78 +/- ##
==========================================
Coverage 85% 85%
==========================================
Files 16 16
Lines 2000 2019 +19
==========================================
+ Hits 1702 1722 +20
+ Misses 298 297 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
… instead Handle the situations where configs doesn't have "pems" keys: Yangtze does not have REQ-403 and the REQ-403 API changed later to pass the PEMs in files, so the clusterd DB only has their path names: Ignore the pems keys if not there and sanitize the rest of the config. - Applies the fix originally developed and tested by Edwin. - Update the tests: - Ensure that the fix works and keeps working across future changes. Co-authored-by: Bernhard Kaindl <[email protected]> Signed-off-by: Edwin Török <[email protected]> (cherry picked from commit e4a80b6)
Signed-off-by: Bernhard Kaindl <[email protected]> (cherry picked from commit 5fd22f8)
bernhardkaindl
changed the title
bernhardkaindl
changed the title
rosslagerwall
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CA-358870: Backport the fixes to filter the XAPI Clusterd DB for XS8, Yangtze:
Fixes for
filter_xapi_clusterd_db():(cherry picked from CA-388587: Fix filtering the
xapi-clusterddband log any errors #67, 9a64b44)KeyErrorifpemsandauthkeydon't exist in DB (backport of @edwintorok's patch)(cherry picked from CA-388587: Fix filtering the
xapi-clusterddband log any errors #67, e4a80b6)If Exceptions would occur in the future, log them to the bugtool log (with testcase for it)
(cherry picked from CA-388587: Fix filtering the
xapi-clusterddband log any errors #67, 5fd22f8)