[FEATURE] StoreyViewsPlugin sort on IfcBuildingStorey elevation #1710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| <meta name="viewport" content="width=device-width, initial-scale=1"> | ||
| <title>xeokit Example</title> | ||
| <link href="../css/pageStyle.css" rel="stylesheet" /> | ||
| <script src="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/5.13.0/js/all.min.js"></script> |
Check warning
Code scanning / CodeQL
Inclusion of functionality from an untrusted source Medium
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the way
StoreyMapsare ordered inStoreyViewsPlugin.storeysList.Ordinarily we sort each
StoreyMapby the lowest point of the 3D boundary of its IfcBuildingStorey.This is a problem when the IfcBuildingStorey contains an element, such as a stairwell or drainpipe, that overlaps with the boundaries of other IfcBuildingStoreys. In this case, the correct spatial ordering is unclear.
This PR makes sorting more robust by sorting the Storeys on the IfcBuildingStorey
elevationattribute, if provided in the data.If not provided, then sorting will fall back on using the boundaries as just described.
Usage example here, with an XKT file that contains metadata that has the elevation attributes on the IfcBuildingStoreys: https://github.com/xeokit/xeokit-sdk/blob/master/examples/navigation/StoreyViewsPlugin_Minimap_Duplex.html