Avoid returning the same InvoiceID (a.o.) for all payments from get_payments #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This breaks all payments tests as get_payment assumed Invoice.InvoiceNumber to not be nil...
|
Ran into a new issue with get_payments getting the proper InvoiceID and -Number; |
jomz
added a commit
to nzffa/xero_gateway
that referenced
this pull request
Dec 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The XPaths used ("//SomeElement") made any node within the response match, but you only want to match from the child nodes...
Test included.
This is a cleaned up version of PR #150; minus the commit that made the library 1.8 compatible again.