Move disableDimming to VideoView #240
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
我的想法是还把 disableDimming 放在 mpv里面，但是可以精简到 core-idle 那个状态的判定下面，core-idle 应该可以精准的表示播放器是否正在播放，正好比较适合。因为 mpvCore 是单例的, 维护是否息屏的状态会更容易一些，如果放在videoview下我怕出现错误调用 disableDimming 的情况。 |
core-idle 下面判断确实更合适 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
参考文档中 MPV_EVENT_SEEK，简化了部分 mpv 事件订阅
disableDimming转移到VideoView中的showLoading/hideLoading中调用，减少了disableDimming到处调用的情况