Added Toggle Tail config in Debug.

[sjoshid]

PR for xi-editor/xi-editor#922

[codecov-io]

Codecov Report

Merging #373 into master will increase coverage by 1.63%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #373      +/-   ##
==========================================
+ Coverage   41.59%   43.23%   +1.63%     
==========================================
  Files          36       36              
  Lines        4130     4138       +8     
==========================================
+ Hits         1718     1789      +71     
+ Misses       2412     2349      -63

Impacted Files	Coverage Δ
Sources/XiEditor/XiCore.swift	89.74% <0%> (-4.86%)	⬇️
Sources/XiEditor/AppDelegate.swift	28.72% <0%> (+0.15%)	⬆️
Sources/XiEditor/RPCSending.swift	55.81% <0%> (-1.17%)	⬇️
Sources/XiEditor/EditView.swift	55.3% <0%> (+0.85%)	⬆️
Sources/XiEditor/XiTextPlane/Atlas.swift	78.57% <0%> (+1.78%)	⬆️
Sources/XiEditor/EditViewController.swift	37.61% <0%> (+10.39%)	⬆️
Sources/XiEditor/ClientImplementation.swift	49.56% <0%> (+10.43%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fb44c6...3c092a0. Read the comment docs.

[mmatoszko]

Super nice and clear PR 👍

[jansol]

The function and RPC are called 'toggle' but what it does looks more like 'set' at a quick glance. This seems somewhat confusing to me. Maybe rename or explain the naming in a comment in the code?

[cmyr]

This is tracking xi-editor/xi-editor#1011; the final shape of this will be determined by decisions there, so holding review until then.

[sjoshid]

@cmyr
Made some progress here. I have followed existing language changed implementation as it is similar in functionality to tail feature.
One thing remaining: disable the toggle tail menu when file doesnt exist.

[cmyr]

@sjoshid This includes a bunch of files I don't think you intended?

A tip I find useful: after updating a PR (and before confirming to open a PR) click on the "files changed" tab and read through the diffs. I very often find mistakes I've made this way!

[sjoshid]

Oops. Sorry about that. Not sure how they sneaked in. I think I did a bunch of useless commits but the final version looks good.