forked from facebookincubator/velox
-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Simplify and optimize duplicate row memory allocations (facebookincub…
…ator#10865) Summary: This PR simplifies the duplicate row memory allocations by using dedicated hash string allocator with one per each partition. All the dedicated hash string allocators are all backup by the memory pool of the top level hash table. Then we can simplify the memory reservation in hash build operator and avoid the unnecessary memory fragements. Now we have to reserve memory from each of the hash build operator for the worst case of duplicate row memory allocations. This PR also make free next row vectors optional which can helps save >10% cpu cycles in hash join list microbenchmark. The free next row vectors are not necessary and most for sanity check. Also current implementation does not guaratee the next row vectors free always get executed as the duplicate row flag is not set correctly. This PR also fixes this by always passing the associated row container when do parallel row insertion. Pull Request resolved: facebookincubator#10865 Test Plan: Run through 10hrs fuzzer test Run shadow for 12 hours without crashes on pnb3_verifier_t10_3 Xstream A/B F3 test suite (with hashtable) passed: x45036005743309881 Reviewed By: kevinwilfong Differential Revision: D61881526 Pulled By: xiaoxmeng
- Loading branch information
1 parent
d1ac079
commit b6fa5c3
Showing
12 changed files
with
170 additions
and
205 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.