Skip to content

Commit

Permalink
opt: disable Qt≤6.7 deprecated features and disable Qt deprecation wa…
Browse files Browse the repository at this point in the history
…rnings
  • Loading branch information
shenlebantongying authored Nov 7, 2024
1 parent c864a9a commit 0214392
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 3 deletions.
6 changes: 6 additions & 0 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,12 @@ endif ()

#### Compile definitions

# Disable deprecated staffs for Qt<=6.7 (Bump this if ever consider bump Qt version)
target_compile_definitions(${GOLDENDICT} PRIVATE
QT_DISABLE_DEPRECATED_UP_TO=0x060700
QT_NO_DEPRECATED_WARNINGS
)

target_compile_definitions(${GOLDENDICT} PUBLIC
CMAKE_USED_HACK # temporal hack to avoid breaking qmake build
MAKE_QTMULTIMEDIA_PLAYER
Expand Down
4 changes: 2 additions & 2 deletions src/macos/macmouseover.mm
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,8 @@ static CGPoint carbonScreenPointFromCocoaScreenPoint( NSPoint cocoaPoint )

UniChar *chars = new UniChar[ length ];
CFStringGetCharacters( str, CFRangeMake( 0, length ), chars );

QString result = QString::fromUtf16( chars, length );
QString result = QString::fromUtf16( (char16_t*)chars, length );

delete[] chars;
return result;
Expand Down
2 changes: 1 addition & 1 deletion website/docs/install.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ Requires Windows 10 (1809 or later).
* For ArchLinux, pre-built binary is available from [archlinuxcn's repo](https://github.com/archlinuxcn/repo/tree/master/archlinuxcn/goldendict-ng-git).
* [Gentoo package from PG_Overlay](https://gitlab.com/Perfect_Gentleman/PG_Overlay/-/tree/master/app-text/goldendict-ng)

Minimum supported "Linux" versions is supposedly the current Ubuntu LTS or Debian's old stable or Qt6.4.
Minimum supported "Linux" version is supposedly the current Ubuntu LTS and Debian's oldstable.

## macOS

Expand Down

0 comments on commit 0214392

Please sign in to comment.