Merge pull request #1763 from xiaoyifang/staged

fix icu mac builds
xiaoyifang · Sep 10, 2024 · 8cb9d11 · 8cb9d11
2 parents cbccc8f + b392c83
commit 8cb9d11
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/cmake/Deps_Unix.cmake b/cmake/Deps_Unix.cmake
@@ -83,6 +83,12 @@ endif ()
 if (WITH_ZIM)
     pkg_check_modules(ZIM REQUIRED IMPORTED_TARGET libzim)
     target_link_libraries(${GOLDENDICT} PRIVATE PkgConfig::ZIM)
+    if (APPLE)
+        # For some reason, icu4c as transitive dependency of libzim may not be copied into app bundle,
+        # so we directly depends on it to help macdeployqt or whatever
+        pkg_check_modules(BREW_ICU_FOR_LIBZIM_FORCE_LINK REQUIRED IMPORTED_TARGET icu-i18n icu-uc)
+        target_link_libraries(${GOLDENDICT} PUBLIC PkgConfig::BREW_ICU_FOR_LIBZIM_FORCE_LINK)
+    endif ()
 endif ()
 
 if (USE_SYSTEM_FMT)