Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things happens in the main event loop can share the same QNetworkAccessManager
#974
Other than
AnkiConnector
andiframehandler
, allQNetworkAccessManager
are created byMainWindow
, then passed down to various places. This means, if the old code is correct, then obtaining the pointer from global (pretty much the same as theMainWindow
) is also correct.We can further remove the
netMgr
parameter fromloadDictioanries/editDictionaries
. And instead, let dictionaries obtain a pointer to theglobalNetworkAccessManager
during initialization.Random related things:
QThread::isMainThread
in Qt6.8 qt/qtbase@a3d5011#diff-4bb5aaa078a4700cf1c8a805176a3d445f6b0408e526612cb0a13fb19f5bd1dbR429-R444