opt: dictionarygroup refactor in articleview #1625
Merged
+120
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/ui/articleview.hh
Outdated
| @@ -35,8 +36,7 @@ class ArticleView: public QWidget | |||
|
|
|||
| ArticleNetworkAccessManager & articleNetMgr; | |||
| AudioPlayerPtr const & audioPlayer; | |||
| std::vector< sptr< Dictionary::Class > > const & allDictionaries; | |||
| Instances::Groups const & groups; | |||
| DictionaryGroup dictionaryGroup; | |||
There was a problem hiding this comment.
std::unique_ptr / QScopedPointer seems better than "QObject with this as parent" in here. They manage the lifetime equally, but the former don't have bloats.
There was a problem hiding this comment.
two different ways to the same goal.
There was a problem hiding this comment.
For objects with no complex deleter, the cost of unique_ptr is zero.
xiaoyifang
force-pushed
the
opt/dictionarygroup
branch
from
ddc5ebb to
96bd752
Compare
xiaoyifang
force-pushed
the
opt/dictionarygroup
branch
from
a4234f4 to
a3dd7ca
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.