xiaoyifang · shenlebantongying · Jul 8, 2024 · Jul 9, 2024
diff --git a/.github/workflows/PR-check-cmake.yml b/.github/workflows/PR-check-cmake.yml
@@ -11,132 +11,136 @@ on:
       - experimental
       - staged
     paths-ignore:
-      - 'docs/**'
-      # - ".github/**"
-      - "howto/**"
+      - "docs/**"
       - "*.md"
       - "locale/**"
+      - "website/**"
 jobs:
   job1:
-    name: ubuntu Build and analyze
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/setup-python@v3
-        with:
-          python-version: '3.9'              
-      - name: Install Qt
-        uses: jurplel/install-qt-action@v3
-        with:
-          # Qt6.4 for testing ubuntu LTS
-          version: 6.4.3
-          arch: gcc_64
-          modules: qtwebengine qtwebchannel qtpositioning qt5compat qtmultimedia qtimageformats qtspeech
-          setup-python: 'false'
-
-      - name: ubuntu install thirdparty dependencies
+    name: Ubuntu
+    runs-on: ubuntu-24.04
+    steps:             
+      - name: Install dependencies
         run: |
-          sudo apt-get install git pkg-config build-essential 
-          sudo apt-get install libvorbis-dev zlib1g-dev libhunspell-dev x11proto-record-dev 
-          sudo apt-get install libxtst-dev liblzo2-dev libbz2-dev 
-          sudo apt-get install libavutil-dev libavformat-dev libeb16-dev
-          sudo apt-get install doxygen libzstd-dev libxkbcommon-dev libgstreamer-plugins-base1.0-0 libgstreamer-gl1.0-0
-          sudo ln -sf /usr/bin/x86_64-linux-gnu-ld.gold /usr/bin/ld
-          sudo apt install libxapian-dev
-
-          #build opencc
-          git clone https://github.com/BYVoid/OpenCC
-          cd OpenCC/
-          make PREFIX=/usr -j$(nproc)
-          sudo make install
-          cd ..
-          sudo apt-get install libzim-dev
+          sudo apt-get install build-essential ninja-build \
+          libvorbis-dev zlib1g-dev libhunspell-dev x11proto-record-dev \
+          libxtst-dev liblzo2-dev libbz2-dev \
+          libavutil-dev libavformat-dev libeb16-dev \
+          libzstd-dev libxkbcommon-dev \
+          libxapian-dev libzim-dev libopencc-dev \
+          qt6-5compat-dev \
+          qt6-base-dev \
+          qt6-multimedia-dev \
+          qt6-speech-dev \
+          qt6-svg-dev \
+          qt6-tools-dev \
+          qt6-tools-dev-tools \
+          qt6-webchannel-dev \
+          qt6-webengine-dev
       - uses: actions/checkout@v4
         with:
           fetch-depth: 0  # Shallow clones should be disabled for a better relevancy of analysis
           submodules: false
-
-      - name: Run build-wrapper
+      - name: Run build
         run: |
-          cmake .
-          cmake --build .
+          mkdir build_dir
+          cmake -S . \
+            -B ./build_dir \
+            -G Ninja
+          cmake --build ./build_dir 
 
   job2:
-    name: windows Build and analyze
+    name: Windows (winlibs)
     runs-on: windows-latest
-    steps:
-      - uses: actions/setup-python@v3
-        with:
-          python-version: '3.9'              
+    steps:            
       - name: Install Qt
-        uses: jurplel/install-qt-action@v3
+        uses: jurplel/install-qt-action@v4
         with:
           version: 6.5.1
           arch: win64_msvc2019_64
-
-          #serialport linuxdeploy need serialport to work.
-          modules: qtwebengine qtwebchannel qtpositioning qt5compat qtmultimedia qtimageformats qtspeech qtserialport
+          modules: qtwebengine qtwebchannel qtpositioning qt5compat qtmultimedia qtimageformats qtspeech 
           setup-python: 'false'
       - uses: ilammy/msvc-dev-cmd@v1
       - uses: actions/checkout@v4
         with:
           fetch-depth: 0  # Shallow clones should be disabled for a better relevancy of analysis
           submodules: true
-
-      - name: Run build-wrapper
+      - name: Run build
         run: |
           cmake -S . -DWITH_FFMPEG_PLAYER=OFF
-          cmake --build . --config Release
+          cmake --build .
   job3:
-    name: macos Build and analyze
+    name: macOS
     runs-on: macos-12
-    steps:
-      - uses: actions/setup-python@v3
-        with:
-          python-version: '3.9'              
-      - name: Install Qt
-        uses: jurplel/install-qt-action@v3
-        with:
-          version: 6.5.1
-          arch: clang_64
-
-          #serialport linuxdeploy need serialport to work.
-          modules: qtwebengine qtwebchannel qtpositioning qt5compat qtmultimedia qtimageformats qtspeech qtserialport
-          setup-python: 'false'
-      - uses: ilammy/msvc-dev-cmd@v1
+    steps:             
       - uses: actions/checkout@v4
         with:
           fetch-depth: 0  # Shallow clones should be disabled for a better relevancy of analysis
           submodules: false
-      - name: install dependencies
+      - name: Install dependencies
         run: |
-          brew install pcre2 harfbuzz freetype
-          brew install cmake ninja python
-          brew install automake
-          brew install autoconf
-          brew install libtool
-          brew install opencc
-
-          brew install speex
-          brew tap homebrew-ffmpeg/ffmpeg
-          brew install homebrew-ffmpeg/ffmpeg/ffmpeg --with-speex
-          brew install libao
-          brew install libiconv
-          brew install lzo bzip2
-          brew install libogg
-          brew install zstd lzip
-          brew install libvorbis --force
-          brew install hunspell
+          brew install \
+          ninja \
+          opencc \
+          ffmpeg \
+          libao \
+          libiconv \
+          bzip2 \
+          lzip \
+          libvorbis \
+          hunspell \
+          xapian \
+          libzim \
+          qt
+
           wget ftp://ftp.sra.co.jp/pub/misc/eb/eb-4.4.3.tar.bz2
           tar xvjf eb-4.4.3.tar.bz2
           cd eb-4.4.3 && ./configure && make -j 8 && sudo make install && cd ..
-          #brew install qt # or use official offline installer
-          brew install  xz lzo 
-          brew install pkg-config
-          brew install xapian
-          brew install libzim
-          brew install icu4c
-      - name: Run build-wrapper
+
+      - name: Run build
         run: |
-          cmake .
-          cmake --build .                  
-
+          mkdir build_dir
+          cmake -S . \
+            -B ./build_dir \
+            -G Ninja
+          cmake --build ./build_dir
+
+  job4:
+    name: Windows (vcpkg)
+    runs-on: windows-latest
+    steps:       
+      - name: Install Qt
+        uses: jurplel/install-qt-action@v4
+        with:
+          version: 6.7.2
+          arch: win64_msvc2019_64
+          modules: qtwebengine qtwebchannel qtpositioning qt5compat qtmultimedia qtimageformats qtspeech 
+          setup-python: 'false'
+      - uses: actions/checkout@v4
+        with:
+          fetch-depth: 0  # Shallow clones should be disabled for a better relevancy of analysis
+          submodules: true
+      - name: Setup vcpkg github caches variables
+        uses: actions/github-script@v7
+        with:
+          script: |
+            core.exportVariable('ACTIONS_CACHE_URL', process.env.ACTIONS_CACHE_URL || '');
+            core.exportVariable('ACTIONS_RUNTIME_TOKEN', process.env.ACTIONS_RUNTIME_TOKEN || '');
+      - name: Run build
+        id: build
+        env:
+          VCPKG_BINARY_SOURCES: "clear;x-gha,readwrite"
+        run: |
+          # Launch-VsDevShell also provides Ninja
+          & 'C:\Program Files\Microsoft Visual Studio\2022\Enterprise\Common7\Tools\Launch-VsDevShell.ps1' `
+            -SkipAutomaticLocation -Arch amd64 -HostArch amd64
+
+          New-Item -Path './build_dir' -ItemType Directory
+          cmake -S . -B "./build_dir" `
+            -G Ninja `
+            -DCMAKE_C_COMPILER="cl.exe" -DCMAKE_CXX_COMPILER="cl.exe" `
+            -DWITH_FFMPEG_PLAYER=OFF `
+            -DUSE_VCPKG=ON `
+            -DCMAKE_TOOLCHAIN_FILE="$env:VCPKG_INSTALLATION_ROOT\scripts\buildsystems\vcpkg.cmake" `
+            -DWITH_VCPKG_BREAKPAD=ON
+          cmake --build "./build_dir"
diff --git a/.github/workflows/PR-check-windows.yml b/.github/workflows/PR-check-windows.yml
@@ -1,24 +1,24 @@
-name: Windows-PR-check
+name: Windows-qmake-PR-check
 concurrency: 
   group: ${{ github.workflow }}-${{ github.ref }}
   cancel-in-progress: true
 on: 
 
   workflow_dispatch:
 
-  pull_request:
-    branches:
-      - dev
-      - master
-      - experimental
-      - staged
-    paths-ignore:
-      - 'docs/**'
-      # - ".github/**"
-      - "howto/**"
-      - "*.md"
-      - "locale/**"
-      - "website/**"
+  # pull_request:
+  #   branches:
+  #     - dev
+  #     - master
+  #     - experimental
+  #     - staged
+  #   paths-ignore:
+  #     - 'docs/**'
+  #     # - ".github/**"
+  #     - "howto/**"
+  #     - "*.md"
+  #     - "locale/**"
+  #     - "website/**"
 
 jobs:
   build:

diff --git a/.github/workflows/release-macos-homebrew.yml b/.github/workflows/release-macos-homebrew.yml
@@ -162,9 +162,9 @@ jobs:
           body: |
             [Install instructions for Windows, macOS and Linux](https://xiaoyifang.github.io/goldendict-ng/install/).
 
-            Filaname pattern: GoldenDict-[version]-[Qt version]-[system name]-...
+            Filename pattern: GoldenDict-[version]-[Qt version]-[system name]-...
 
-            For Linux, released vesion is on Flathub -> [io.github.xiaoyifang.goldendict_ng](https://flathub.org/apps/io.github.xiaoyifang.goldendict_ng).
+            For Linux, released version is on Flathub -> [io.github.xiaoyifang.goldendict_ng](https://flathub.org/apps/io.github.xiaoyifang.goldendict_ng).
 
             Based on branch: ${{github.ref_name}}
 

diff --git a/.github/workflows/release-windows-vcpkg-cmake.yml b/.github/workflows/release-windows-vcpkg-cmake.yml
@@ -147,9 +147,9 @@ jobs:
           $changeNotes = "
           [Install instructions for Windows, macOS and Linux](https://xiaoyifang.github.io/goldendict-ng/install/).
 
-          Filaname pattern: GoldenDict-[version]-[Qt version]-[system name]-...
+          Filename pattern: GoldenDict-[version]-[Qt version]-[system name]-...
 
-          For Linux, released vesion is on Flathub -> [io.github.xiaoyifang.goldendict_ng](https://flathub.org/apps/io.github.xiaoyifang.goldendict_ng).
+          For Linux, released version is on Flathub -> [io.github.xiaoyifang.goldendict_ng](https://flathub.org/apps/io.github.xiaoyifang.goldendict_ng).
 
           Based on branch: ${{github.ref_name}}