Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add founded dictionaries bar in the scanpop dialog #2050

Merged
merged 14 commits into from
Jan 2, 2025

Conversation

xiaoyifang
Copy link
Owner

@xiaoyifang xiaoyifang commented Dec 30, 2024

image

add a new toolbar at the right side(default) , the toolbar will hold all the found dictionaries which will navigate to the target dictionary when clicked.

@xiaoyifang xiaoyifang marked this pull request as draft December 30, 2024 05:57
@xiaoyifang xiaoyifang force-pushed the opt/scanpop-dictionary branch from 4eadb4c to be0166e Compare December 30, 2024 05:58
@xiaoyifang xiaoyifang changed the title Opt/scanpop dictionary opt: add founded dictionaries bar in the scanpop dialog Dec 31, 2024
@xiaoyifang xiaoyifang marked this pull request as ready for review December 31, 2024 09:21
@xiaoyifang
Copy link
Owner Author

#2008

@xiaoyifang xiaoyifang force-pushed the opt/scanpop-dictionary branch from 9f08112 to 6cfff2d Compare January 2, 2025 07:23
@xiaoyifang xiaoyifang enabled auto-merge (squash) January 2, 2025 07:23
@xiaoyifang xiaoyifang changed the title opt: add founded dictionaries bar in the scanpop dialog feat: add founded dictionaries bar in the scanpop dialog Jan 2, 2025
@xiaoyifang xiaoyifang disabled auto-merge January 2, 2025 07:23
@xiaoyifang xiaoyifang enabled auto-merge (squash) January 2, 2025 07:23
@xiaoyifang xiaoyifang merged commit f13e223 into staged Jan 2, 2025
9 checks passed
@xiaoyifang xiaoyifang deleted the opt/scanpop-dictionary branch January 2, 2025 07:29
Copy link

sonarqubecloud bot commented Jan 2, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant