add jthread repo #5236
Merged
add jthread repo #5236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
star-hengxing
requested changes
Sep 15, 2024
packages/j/jthread/xmake.lua
Outdated
| add_versions("2023.08.18", "719413043807b77448df3ba1c749798fb72ee459") | ||
| add_deps("cmake") | ||
|
|
||
| add_patches("1.3.3", "patches/1.3.3/cmakelist.patch", "4c5162f128f31ebee63805db1dbed0a17fc02b2661958b80468fcffc394d7f4e") |
There was a problem hiding this comment.
如果去掉补丁会在shared=true时，仍然会生成静态库
waruqi
reviewed
Sep 15, 2024
packages/j/jthread/xmake.lua
Outdated
| on_test(function (package) | ||
| assert(package:check_cxxsnippets({test = [[ | ||
| using namespace jthread; | ||
| class TestThread : public JThread{ |
star-hengxing
requested changes
Sep 15, 2024
packages/j/jrtplib/xmake.lua
Outdated
| add_deps("cmake", "jthread", "srtp") | ||
|
|
||
| on_install(function (package) | ||
| io.replace("src/CMakeLists.txt", [[ "Enable -Wall -Wextra -Werror" ON]], [[ "Enable -Wall -Wextra -Werror" OFF]]) |
There was a problem hiding this comment.
这里是一个 option，直接 -DJRTPLIB_WARNINGSASERRORS=OFF 就行
There was a problem hiding this comment.
但是这里只要时gcc工具链就会设置为ON， 所以才如此修改
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jthread 是jrtplib所依赖的库，所以在此添加支持