Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update metrics 2 #148

Closed
wants to merge 12 commits into from
Closed

Update metrics 2 #148

wants to merge 12 commits into from

Conversation

schmidtw
Copy link
Member

Update & add several metrics to help debug #145

@CLAassistant
Copy link

CLAassistant commented Jul 8, 2019

CLA assistant check
All committers have signed the CLA.

schmidtw and others added 9 commits July 15, 2019 16:28
#147)

* Fix the race condition and make the alternate urls automatically round-robin along the way.

* Add the randomization of the starting URL.
* fix dockerfiles

* move glide fetching to install step
…t need to add invalid values to the metrics expected.
Add a fix where a panic in the sender go routine doesn't kill the ent…
(cherry picked from commit 231d057)

Update the expired metric to explicitly cover only messages that expire in the queue.  A new label is present for prior to queueing.

(cherry picked from commit 9c92da6)
@codecov-io
Copy link

Codecov Report

Merging #148 into master will increase coverage by 2.94%.
The diff coverage is 89.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #148      +/-   ##
==========================================
+ Coverage   68.38%   71.32%   +2.94%     
==========================================
  Files           7        7              
  Lines         639      715      +76     
==========================================
+ Hits          437      510      +73     
- Misses        190      193       +3     
  Partials       12       12
Impacted Files Coverage Δ
src/caduceus/metrics.go 100% <100%> (ø) ⬆️
src/caduceus/outboundSender.go 83.16% <80.76%> (+1.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a201f9...36f82b6. Read the comment docs.

@schmidtw schmidtw closed this Aug 29, 2019
@schmidtw schmidtw deleted the update-metrics-2 branch August 29, 2019 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants