added configurable device id parsing #228
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- moved creation of the device ID parser from configuration to its own function, called from the main function. - added log statements for non-critical problems such as parsing a message failing or part of setting up the parser with configuration failing. - added helpful errors instead of placeholders. - started on unit tests; for the new function, added an inital skeleton of cases I plan to test.
kcajmagic
approved these changes
Aug 4, 2020
|
@kristinaspring and I talked about the changes & we think the changes bring to light a few important issues that she highlights in issue #229 . I don't think Caduceus should be in the business of needing to do "smart parsing" of the wrp locators used as the wrp.source / dest fields to figure out the device id. It unfortunately has stepped down that path, but we should reconsider if there is a better way to achieve the desired outcome versus this approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #222
uses the new wrp-listener library:
https://github.com/xmidt-org/wrp-listener/tree/main/wrpParser