Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support xmlStructuredErrorFunc definition change in libxml2 #214

Closed
wants to merge 1 commit into from
Closed

Support xmlStructuredErrorFunc definition change in libxml2 #214

wants to merge 1 commit into from

Conversation

yahonda
Copy link

@yahonda yahonda commented Mar 12, 2024

This pull request supports xmlStructuredErrorFunc definition change in libxml2 via https://gitlab.gnome.org/GNOME/libxml2/-/commit/61034116d0a3c8b295c6137956adc3ae55720711

Fix #213
Thank you for providing a way to fix https://bugs.freebsd.org/bugzilla/attachment.cgi?id=248824&action=diff

@yahonda
Copy link
Author

yahonda commented Mar 12, 2024

I am unable to address the trailing ^M is removed when I edit this file via vim or Visual Studio Code on my macOS. Copy and paste the git diff does not show the diff color in red correctly, let me upload the screenshot.

Screenshot 2024-03-12 at 10 39 15 AM

@cfis
Copy link
Member

cfis commented Mar 12, 2024

I am confused. The header files shows the constant is needed:

https://gitlab.gnome.org/GNOME/libxml2/-/blob/master/include/libxml/xmlerror.h?ref_type=heads#L865

typedef void (*xmlStructuredErrorFunc) (void *userData, const xmlError *error);

The commit you pointed to previously shows the const being added.

https://gitlab.gnome.org/GNOME/libxml2/-/commit/61034116d0a3c8b295c6137956adc3ae55720711

And compiling with libxml 2.12.5-1 works fine with gcc and msvc.

What am I missing?

@cfis
Copy link
Member

cfis commented Mar 12, 2024

Ok, this is the issue:

1476a2d

That fix is needed for new versions of libxml but breaks old versions. I should have added a version check there.

@cfis
Copy link
Member

cfis commented Mar 12, 2024

Ok, fixed in c7933a7.

Sorry not to realize this error sooner - but thanks for reporting!

@cfis cfis closed this Mar 12, 2024
@yahonda yahonda deleted the diag213 branch March 12, 2024 05:39
@yahonda
Copy link
Author

yahonda commented Mar 12, 2024

Thank you for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bundle exec rake compile gets `error: incompatible function pointer types
2 participants