XIP-36: Frames Support in Review status #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhaaaa
commented
May 13, 2024
jhaaaa
commented
May 13, 2024
| 3. [Open Graph Proxy service](https://github.com/neekolas/og-proxy) | ||
| Still missing support for proxying requests for images. This support will be a hard requirement for launch. | ||
|
|
||
| Here are some specifications you might also want to explore as a part of working with these reference implementations: |
There was a problem hiding this comment.
See below - this is where I added the link to the Open Frames spec as suggested by Nick.
I also added a link to the Farcaster Frames spec, just to be comprehensive.
jhaaaa
commented
May 13, 2024
|
|
||
| In the Farcaster model of Frames, messages are signed on a server by the app and the server makes the POST request to the Frame URL. This means the Frame app developer only sees requests from the server IP and never the client. | ||
|
|
||
| However, Farcaster clients, like Warpcast, download the Frame image directly. This [leaks the IP address of the viewer to the Frame developer](https://twitter.com/danfinlay/status/1752500815200399633?t=1psurRGh-JTii3AHjvUrMg). According to a reply on X, they are "[working on it](https://x.com/dwr/status/1752506807548072140?s=20)." |
There was a problem hiding this comment.
Do we know if they've fixed this?
jhaaaa
commented
May 13, 2024
|
|
||
| ## Reference implementations | ||
|
|
||
| We've developed reference implementations for all three components required to enable Frames on XMTP: |
There was a problem hiding this comment.
For each of the 3 items below, we call out areas that need updates. Might we have any updates to share?
neekolas
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready for Review status.
Left a few comments for review by @neekolas and @daria-github - thank you!