Signature verification requests routing #1094
Conversation
* imlement SmartContractVerification for lots of chainids * remove comment
…fsite/scw-libxmtp
* move file parser * load in verifier * cleanup * cleanup * log malformatted url * chainurls.json * closure, dont expect * go gentle into that good night * default * lint * cleanup
* block number optional
Your org has enabled the Graphite merge queue for merging into mainAdd the label “queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
Before merging should:
|
* wip * wip * patchwork * a few fixes * update to use scw verifier for inbox_ids * Fix build errors * fix signature * lint * remove debug * lint * revert gen protos script * restore tests too * feedback * cleanup, feedback * cleanup * cleanup * hash * Actually do the work, and take the hash from the proto * cleanup * more cleanup * not using error msg * use latest proto * wip * cleanup * nicer error * revert * unnecessary change * remove env logger * cleanup * false in place of none * lint
|
Depends on xmtp/proto#211 |
| responses.push(handle); | ||
| } | ||
|
|
||
| let responses: Vec<_> = try_join_all(responses) |
There was a problem hiding this comment.
We might need to be careful here -- try_join_all will abort the entire operation if only one of the futures fail. It might be better to use join_all here, emit a log if one of the futures fail and transform that failed future to is_valid: false
There was a problem hiding this comment.
Could also return a Vec<> of errors or something. Might be ok to do it in followup PR as long as an issue is created
There was a problem hiding this comment.
Giving that a little more thought, I should add an error message field to the validation response, so this doesn't turn into a black box. Let me get a quick proto pr up.
"Create
MultiChainSignatureVerifierthat routes signature verification requests toRpcSmartContractWalletVerifierinstances configured with a RPC URL for the correct chain."Part of #1070
Depends on xmtp/proto#211