MLS Validation Service for SCW #1098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neekolas
reviewed
Oct 1, 2024
neekolas
reviewed
Oct 1, 2024
neekolas
reviewed
Oct 1, 2024
neekolas
reviewed
Oct 1, 2024
neekolas
reviewed
Oct 1, 2024
neekolas
reviewed
Oct 1, 2024
neekolas
reviewed
Oct 1, 2024
neekolas
reviewed
Oct 2, 2024
neekolas
reviewed
Oct 2, 2024
insipx
reviewed
Oct 2, 2024
There was a problem hiding this comment.
Looks good!
Should we wait until xmtp/proto#211 / 212 is merged to merge this?
doing ./dev/gen_protos on this branch gives a different history then the generated protos, is that something to worry about?
|
@insipx Correct, I'd like to merge the proto branch (xmtp/proto#211) before this makes it to main. |
neekolas
reviewed
Oct 2, 2024
neekolas
approved these changes
Oct 3, 2024
codabrink
added a commit
that referenced
this pull request
Oct 3, 2024
* url parser * imlement SmartContractVerification for lots of chainids * explain unwraps * naming * imlement SmartContractVerification for lots of chainids (#1086) * imlement SmartContractVerification for lots of chainids * remove comment * move file parser (#1087) * move file parser * load in verifier * cleanup * cleanup * log malformatted url * chainurls.json * closure, dont expect * go gentle into that good night * default * lint * cleanup * Add block number (#1089) * block number optional * rename multi contract verifier * update permissions that changed for some reason * remove fake.com * scw verifier in bindings * MLS Validation Service for SCW (#1098) * wip * wip * patchwork * a few fixes * update to use scw verifier for inbox_ids * Fix build errors * fix signature * lint * remove debug * lint * revert gen protos script * restore tests too * feedback * cleanup, feedback * cleanup * cleanup * hash * Actually do the work, and take the hash from the proto * cleanup * more cleanup * not using error msg * use latest proto * wip * cleanup * nicer error * revert * unnecessary change * remove env logger * cleanup * false in place of none * lint * error message in the result --------- Co-authored-by: Dakota Brink <[email protected]> Co-authored-by: Andrew Plaza <[email protected]> Co-authored-by: Andrew Plaza <[email protected]> Co-authored-by: Dakota Brink <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With updated proto: xmtp/proto#211