-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix WASM tests (138/151) #1100
Merged
Merged
Fix WASM tests (138/151) #1100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into mainAdd the label “queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
merging this because tests outside of streaming tests are good to go, and the wasm-backend can be split into its own repository |
insipx
added a commit
that referenced
this pull request
Oct 16, 2024
* bare minimum wasm sqlite backend (#905) Functions Ported from diesel Co-authored-by: Ry Racherbaumer <[email protected]> * Statement Stream for AsyncConnection::Load (#961) * Organize wasm tests (#995) * fix vscode configuration for backend * Backend Implementations for wasm diesel (#1030) * free memory after serialization * Dont use r2d2 for WebAssembly (#1065) * create interface for native/wasm EncryptedMessageStore * create interface for spawning tasks onto the global executor in native/wasm * Get most wasm tests passing (138/151) (#1100) * try to correctly pin openssl-sys to 0.9.92 * Update WASM bindings (#1122) * Update VSCode workspace settings * Do not pin openssl --------- Co-authored-by: Ry Racherbaumer <[email protected]> Co-authored-by: Dakota Brink <[email protected]> Co-authored-by: Dakota Brink <[email protected]> Co-authored-by: vking45 <[email protected]> Co-authored-by: Ry Racherbaumer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests in need of fixing
xmtp_mls::groups::tests::test_add_missing_installationsxmtp_mls::groups::tests::test_key_update (WASM Alloc Error, higher prio)Inter-related failing subscribe/stream tests
anything passing on its own but not while other tests are running is a concurrency issue related to the
with_connection
closure, which creates and passes an ephemeral db as a test harness. Ephemeral dbs are probably treated differently in OPFS causing these tests to fail when the in-memory db is opened by other tests.closes #941