Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WASM tests (138/151) #1100

Merged
merged 4 commits into from
Oct 2, 2024
Merged

Fix WASM tests (138/151) #1100

merged 4 commits into from
Oct 2, 2024

Conversation

insipx
Copy link
Contributor

@insipx insipx commented Sep 30, 2024

Tests in need of fixing

  • xmtp_mls::storage::encrypted_store::group::tests::test_installations_last_checked_is_updated (passes on its own)
  • xmtp_mls::storage::encrypted_store::group::tests::test_find_groups (passes on its own)
  • xmtp_mls::groups::tests::process_messages_abort_on_retryable_error - wasm backend needs better error handling (behavior is correct but matching on msg strings and webassembly backend errors are not the same)
  • xmtp_mls::groups::tests::test_add_missing_installations
  • xmtp_mls::groups::tests::test_key_update (WASM Alloc Error, higher prio)
  • xmtp_mls::storage::encrypted_store::group_message::tests::it_cannot_insert_message_without_group Error message discrepancy

Inter-related failing subscribe/stream tests

  • xmtp_mls::subscriptions::tests::test_self_group_creation
  • xmtp_mls::subscriptions::tests::test_stream_all_messages_changing_group_list
  • xmtp_mls::subscriptions::tests::test_stream_all_messages_unchanging_group_list
  • xmtp_mls::subscriptions::tests::test_stream_messages
  • xmtp_mls::subscriptions::tests::test_stream_welcomes
  • xmtp_mls::groups::subscriptions::tests::test_subscribe_membership_changes
  • xmtp_mls::groups::subscriptions::tests::test_subscribe_multiple
  • xmtp_mls::groups::subscriptions::tests::test_subscribe_messages

anything passing on its own but not while other tests are running is a concurrency issue related to the with_connection closure, which creates and passes an ephemeral db as a test harness. Ephemeral dbs are probably treated differently in OPFS causing these tests to fail when the in-memory db is opened by other tests.
closes #941

@insipx insipx requested review from a team as code owners September 30, 2024 23:48
Copy link

graphite-app bot commented Sep 30, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@insipx insipx changed the base branch from main to wasm-backend September 30, 2024 23:48
@insipx insipx removed the request for review from a team October 1, 2024 14:16
@insipx insipx changed the title Fix WASM tests (142/160) Fix WASM tests (142/158) Oct 1, 2024
@insipx insipx changed the title Fix WASM tests (142/158) Fix WASM tests (142/156) Oct 1, 2024
@insipx insipx changed the title Fix WASM tests (142/156) Fix WASM tests (136/151) Oct 1, 2024
@insipx insipx changed the title Fix WASM tests (136/151) Fix WASM tests (137/151) Oct 1, 2024
@insipx insipx changed the title Fix WASM tests (137/151) Fix WASM tests (138/151) Oct 2, 2024
@insipx
Copy link
Contributor Author

insipx commented Oct 2, 2024

merging this because tests outside of streaming tests are good to go, and the wasm-backend can be split into its own repository

@insipx insipx merged commit 895ec4a into wasm-backend Oct 2, 2024
8 checks passed
@insipx insipx deleted the insipx/wasm-debugging branch October 2, 2024 18:31
insipx added a commit that referenced this pull request Oct 16, 2024
* bare minimum wasm sqlite backend (#905)

Functions Ported from diesel

Co-authored-by: Ry Racherbaumer <[email protected]>

* Statement Stream for AsyncConnection::Load (#961)

* Organize wasm tests (#995)

* fix vscode configuration for backend

* Backend Implementations for wasm diesel (#1030)

* free memory after serialization

* Dont use r2d2 for WebAssembly (#1065)

* create interface for native/wasm EncryptedMessageStore
* create interface for spawning tasks onto the global executor in native/wasm

* Get most wasm tests passing (138/151) (#1100)

* try to correctly pin openssl-sys to 0.9.92

* Update WASM bindings (#1122)

* Update VSCode workspace settings

* Do not pin openssl

---------

Co-authored-by: Ry Racherbaumer <[email protected]>
Co-authored-by: Dakota Brink <[email protected]>
Co-authored-by: Dakota Brink <[email protected]>
Co-authored-by: vking45 <[email protected]>
Co-authored-by: Ry Racherbaumer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant