Make general conversation to encompass group dms and groups. #1138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into mainAdd the label “queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
nplasterer
commented
Oct 15, 2024
| @@ -224,7 +225,7 @@ pub struct FindGroupParams { | |||
| pub created_after_ns: Option<i64>, | |||
| pub created_before_ns: Option<i64>, | |||
| pub limit: Option<i64>, | |||
| pub include_dm_groups: bool, | |||
| pub conversation_type: Option<ConversationType>, | |||
There was a problem hiding this comment.
I changed all these include_dm booleans to conversation_type so that we could have all 3 options
just dms, just groups, and both.
nplasterer
commented
Oct 15, 2024
| /// Consent is for a group | ||
| GroupId = 1, | ||
| /// Consent is for a conversation | ||
| ConversationId = 1, |
There was a problem hiding this comment.
Since it is just a number under the hood this rename should have no effect on existing records.
codabrink
approved these changes
Oct 15, 2024
insipx
approved these changes
Oct 15, 2024
|
nice! Much prefer enums to booleans |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1130
Brings the language in the bindings more inline with conversation than group to make it easier to understand with groupDMs.
Adds a bunch of specific dm and group functionality to allow backwards compatibility for V2 migrations.