Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom build for bindings_wasm #1148

Merged
merged 3 commits into from
Oct 17, 2024
Merged

Custom build for bindings_wasm #1148

merged 3 commits into from
Oct 17, 2024

Conversation

insipx
Copy link
Contributor

@insipx insipx commented Oct 17, 2024

wasm_bindgen 0.2.95 removed split-linked-modules by default, which made wasm-pack builds fail, since wasm-pack does not support the option.

This adds a cargo xtask to build bindings_wasm, in the same way as wasm-pack. This also allows us to further customize the build with wasm-opt options as well, and I was able to shave off a few more bytes from the generated wasm blob.

Building the bindings_wasm/dist is now cargo xtask build BindingsWasm

@insipx insipx requested review from a team as code owners October 17, 2024 16:44
@insipx insipx enabled auto-merge (squash) October 17, 2024 16:48
Copy link

graphite-app bot commented Oct 17, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@insipx insipx merged commit 18ca7b7 into main Oct 17, 2024
9 checks passed
@insipx insipx deleted the insipx/xtask branch October 17, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants