Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up empty intents #969

Merged
merged 6 commits into from
Aug 16, 2024
Merged

Clean up empty intents #969

merged 6 commits into from
Aug 16, 2024
+161 −47

Conversation

neekolas
Copy link
Contributor

tl;dr

  • We recently made a change where get_publish_intent_data returns an Option, but we were not properly handling the None value of the return.
  • In the case where there is no publish intent data, we should delete the intent since there is nothing left to do.

@neekolas neekolas requested a review from a team as a code owner August 16, 2024 04:13
nplasterer
nplasterer approved these changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@nplasterer nplasterer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find!

@neekolas neekolas changed the base branch from np/repro-forked-groups-installations to main August 16, 2024 05:27
@neekolas neekolas merged commit 657d696 into main Aug 16, 2024
6 checks passed
@neekolas neekolas deleted the nm/clean-up-empty-intents branch August 16, 2024 05:38
This was referenced Aug 16, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nplasterer nplasterer nplasterer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neekolas @nplasterer