Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenMLS Updates #21

Closed
wants to merge 26 commits into from
Closed

OpenMLS Updates #21

wants to merge 26 commits into from

Commits on Jan 25, 2024

  1. Enable Wasm Tests (openmls#1483)

    Co-authored-by: Jan Winkelmann (keks) <[email protected]>
    keks and keks authored Jan 25, 2024
    Configuration menu
    Copy the full SHA
    5052cbe View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2024

  1. Configuration menu
    Copy the full SHA
    a6b8e7d View commit details
    Browse the repository at this point in the history
  2. Fix typo in documentation (openmls#1497)

    Fix typo in documentation: Member -> External
    
    Co-authored-by: raphaelrobert <[email protected]>
    JonasVautherin and raphaelrobert authored Feb 11, 2024
    Configuration menu
    Copy the full SHA
    c178e41 View commit details
    Browse the repository at this point in the history
  3. build: bump codecov/codecov-action from 3 to 4 (openmls#1492)

    Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 3 to 4.
    - [Release notes](https://github.com/codecov/codecov-action/releases)
    - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
    - [Commits](codecov/codecov-action@v3...v4)
    
    ---
    updated-dependencies:
    - dependency-name: codecov/codecov-action
      dependency-type: direct:production
      update-type: version-update:semver-major
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    Co-authored-by: raphaelrobert <[email protected]>
    dependabot[bot] and raphaelrobert authored Feb 11, 2024
    Configuration menu
    Copy the full SHA
    8cad06d View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2024

  1. Fix validation bug (openmls#1491)

    This PR addresses issue openmls#1487. The problem is that currently the list of extensions in a GroupContextExtensions proposal is compared against the capabilities of the current members. Instead, it needs to
    
     -   check that the RequiredCapabilities of the group are satisfied by all members of the group
     -   check that the types of all extensions in the proposal are in the RequiredCapabilities.
    
    This PR also adds a method on the RequiredCapabilitiesExtension for checking whether an extension type is supported. This is needed because the extension types defined in the RFC are supported implicitly, so we also have to compare against the defaults. The defaults are defined close to the Capabilities struct and used to be private to these modules. I made the one for extension types pub(crate) so I can check against it.
    
    ---------
    
    Co-authored-by: Jan Winkelmann (keks) <[email protected]>
    Co-authored-by: raphaelrobert <[email protected]>
    3 people authored Feb 13, 2024
    Configuration menu
    Copy the full SHA
    df1944c View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2024

  1. Configuration menu
    Copy the full SHA
    95664e4 View commit details
    Browse the repository at this point in the history
  2. Improve processing (openmls#1495)

    * Improve processing
    
    * Fix typos
    
    Co-authored-by: Jonas Vautherin <[email protected]>
    
    ---------
    
    Co-authored-by: Jonas Vautherin <[email protected]>
    raphaelrobert and JonasVautherin authored Feb 14, 2024
    Configuration menu
    Copy the full SHA
    af85443 View commit details
    Browse the repository at this point in the history
  3. Remove unnecessary cloning of proposals (openmls#1498)

    * Remove unnecessary cloning of proposals
    
    * Remove to_owned()
    
    ---------
    
    Co-authored-by: Konrad Kohbrok <[email protected]>
    raphaelrobert and kkohbrok authored Feb 14, 2024
    Configuration menu
    Copy the full SHA
    4d6eb49 View commit details
    Browse the repository at this point in the history
  4. Cleanup unused CoreGroup methods (openmls#1499)

    * Cleanup unused CoreGroup methods
    
    * Address review comments
    raphaelrobert authored Feb 14, 2024
    Configuration menu
    Copy the full SHA
    e7578f4 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2024

  1. Introduce InitKey type for KeyPackages (openmls#1500)

    * Introduce InitKey type for KeyPackages
    
    * Address review comments
    raphaelrobert authored Feb 19, 2024
    Configuration menu
    Copy the full SHA
    3a0e6c8 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2024

  1. Allow more credentials (openmls#1488)

    This commit changes OpenMLS such that it can handle arbitrary credentials, as long as they are encoded as a variable-length vector.
    franziskuskiefer authored Feb 21, 2024
    Configuration menu
    Copy the full SHA
    1bd5821 View commit details
    Browse the repository at this point in the history
  2. Check for last resort in core_group/new_from_welcome (openmls#1503)

    * check for last resort in core_group/new_from_welcome
    
    * test join_multiple_groups_last_resort_extension
    
    * changelog includes PR#1503
    
    ---------
    
    Co-authored-by: Joseph Lukefahr <[email protected]>
    Co-authored-by: Konrad Kohbrok <[email protected]>
    Co-authored-by: Franziskus Kiefer <[email protected]>
    4 people authored Feb 21, 2024
    Configuration menu
    Copy the full SHA
    b572335 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2024

  1. Configuration menu
    Copy the full SHA
    6cea0a1 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2024

  1. Add StagedCoreWelcome and StagedWelcome (openmls#1506)

    This commit adds the above types to make it possible to inspect the content
    of a Welcome message before joining a group.
    
    Fixes: openmls#1326 openmls#1506
    Co-authored-by: raphaelrobert <[email protected]>
    keks and raphaelrobert authored Feb 28, 2024
    Configuration menu
    Copy the full SHA
    76335fc View commit details
    Browse the repository at this point in the history

Commits on Feb 29, 2024

  1. Configuration menu
    Copy the full SHA
    bc3edbe View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2024

  1. Configuration menu
    Copy the full SHA
    85d18c9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ca9757f View commit details
    Browse the repository at this point in the history
  3. Add Basic Wasm Bindings and add CI Workflow to Measure Size (openmls#…

    …1525)
    
    This PR adds minimal Wasm bindings and example code, and a github action workflow that measures the size of the built bundle (currently around 1.2MB uncompressed, 450kB gzip'd). It fails when it gets significantly larger.
    
    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: Franziskus Kiefer <[email protected]>
    keks and franziskuskiefer authored Mar 12, 2024
    Configuration menu
    Copy the full SHA
    b1b0a23 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2024

  1. Improve BasicCredential (openmls#1527)

    * Improve BasicCredential
    
    * Address review comments
    
    * Fix new CI errors
    raphaelrobert authored Mar 13, 2024
    Configuration menu
    Copy the full SHA
    8392840 View commit details
    Browse the repository at this point in the history
  2. Small API improvements (openmls#1531)

    * add DeserializeBytes impl for MlsMessageIn
    
    * add getter for body of MlsMessageOut
    
    * add getter for MlsGroup extensions
    
    * expose group info extensions and signature
    
    * expose PublicMessage content type
    
    * add convenience function to mark kp as last resort
    kkohbrok authored Mar 13, 2024
    Configuration menu
    Copy the full SHA
    f3c10c1 View commit details
    Browse the repository at this point in the history
  3. Fix metadata and build profiles (openmls#1532)

    Co-authored-by: Jan Winkelmann (keks) <[email protected]>
    Co-authored-by: raphaelrobert <[email protected]>
    3 people authored Mar 13, 2024
    Configuration menu
    Copy the full SHA
    6469c50 View commit details
    Browse the repository at this point in the history
  4. Make MlsGroup::clear_pending_proposals public (openmls#1516)

    * WIP: function probably works
    
    * clear_pendind_proposals made public
    
    * changelog entry for PR#1516
    
    * additional comments warning against use of clear_pending_proposals
    
    * additional logic in clearing pending proposals
    
    * improved grammar and code placement for clear_pending_proposals
    
    ---------
    
    Co-authored-by: Joseph Lukefahr <[email protected]>
    Co-authored-by: raphaelrobert <[email protected]>
    3 people authored Mar 13, 2024
    Configuration menu
    Copy the full SHA
    069c6f5 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2024

  1. Make StagedWelcome consume Welcome instead of MlsMessageIn (openmls#1533

    )
    
    In openmls#1506 we not only added the StagedWelcome types, but also made the methods to create them consume an MlsMessageIn instead of a Welcome. This was done at the time because there was the open issue openmls#1326 that asked to do this, and we didn't check whether that really was a good idea.
    
    It wasn't.
    
    This PR keeps StagedWelcome, but makes the method that create these structs a Welcome instead of a MlsMessageIn.
    
    Fixes openmls#1519.
    keks authored Mar 14, 2024
    Configuration menu
    Copy the full SHA
    85bd5e7 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2024

  1. Configuration menu
    Copy the full SHA
    656626a View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2024

  1. Configuration menu
    Copy the full SHA
    1007599 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2024

  1. Merge remote-tracking branch 'upstream/main' into em/openmls-updates

    # Conflicts:
    #	openmls/src/extensions/test_extensions.rs
    #	openmls/src/group/core_group/new_from_welcome.rs
    #	openmls/src/group/errors.rs
    #	openmls/src/group/public_group/validation.rs
    zombieobject committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    df47a9a View commit details
    Browse the repository at this point in the history