Add GRPC keepalives back #214
Conversation
🦋 Changeset detectedLatest commit: fb2a9cd The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| local: "localhost:5556", | ||
| } | ||
|
|
||
| const SLEEP_TIME = 1000 | ||
| const MAX_RETRIES = 4 | ||
|
|
||
| const clientOptions = { | ||
| "grpc.keepalive_timeout_ms": 1000 * 10, // 10 seconds | ||
| "grpc.keepalive_time_ms": 1000 * 30, // 30 seconds |
There was a problem hiding this comment.
I'm not sure I understand the relationship between these and the 15 second timeout on the nodes
There was a problem hiding this comment.
15 second on the node is the floor that the node will allow before it gets angry. We don't need 15 seconds on servers where we have pretty reliable internet. It's helpful on the phone where the keepalives can help detect connection drops.
Arguably even 30 seconds is needlessly low. The reports of connection failures happen around the 5 minute mark.
tl;dr