Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sleep when no logs #110

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Sleep when no logs #110

merged 1 commit into from
Aug 13, 2024

Conversation

neekolas
Copy link
Contributor

@neekolas neekolas commented Aug 12, 2024

tl;dr

  • Addresses PR feedback and has the indexer sleep for 1 second when no logs are received.

Potential improvements

  • Start with a smaller sleep time and use exponential backoff

Copy link
Contributor Author

neekolas commented Aug 12, 2024

@neekolas neekolas marked this pull request as ready for review August 12, 2024 22:28
@neekolas neekolas force-pushed the 08-10-use_new_node_contract_in_registry branch from 601c7c1 to 9bb66a2 Compare August 12, 2024 22:59
@neekolas neekolas force-pushed the 08-10-use_new_node_contract_in_registry branch from 9bb66a2 to 893cbec Compare August 12, 2024 23:56
@neekolas neekolas force-pushed the 08-10-use_new_node_contract_in_registry branch from 893cbec to 59a23af Compare August 12, 2024 23:58
@neekolas neekolas force-pushed the 08-10-use_new_node_contract_in_registry branch from 59a23af to e2d7da7 Compare August 13, 2024 00:32
@neekolas neekolas force-pushed the 08-12-sleep_when_no_logs branch 2 times, most recently from 6097b9a to dc1e96e Compare August 13, 2024 01:24
Copy link
Contributor Author

neekolas commented Aug 13, 2024

Merge activity

  • Aug 13, 1:59 PM PDT: @neekolas started a stack merge that includes this pull request via Graphite.
  • Aug 13, 2:02 PM PDT: Graphite rebased this pull request as part of a merge.
  • Aug 13, 2:03 PM PDT: @neekolas merged this pull request with Graphite.

@neekolas neekolas changed the base branch from 08-10-use_new_node_contract_in_registry to graphite-base/110 August 13, 2024 21:00
@neekolas neekolas changed the base branch from graphite-base/110 to main August 13, 2024 21:00
@neekolas neekolas merged commit 3bffba4 into main Aug 13, 2024
4 checks passed
@neekolas neekolas deleted the 08-12-sleep_when_no_logs branch August 13, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants