Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename testing to testutils #121

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Rename testing to testutils #121

merged 1 commit into from
Aug 29, 2024

Conversation

neekolas
Copy link
Contributor

@neekolas neekolas commented Aug 29, 2024 •
edited
Loading

tl;dr

  • It was annoying having to alias the testing package everywhere it was used because the name conflicts with the standard testing package. This renames it

@neekolas Graphite App
Copy link
Contributor Author

neekolas commented Aug 29, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @neekolas and the rest of your teammates on Graphite Graphite

@neekolas neekolas mentioned this pull request Aug 29, 2024
Merged
@neekolas neekolas marked this pull request as ready for review August 29, 2024 02:55
@neekolas neekolas mentioned this pull request Aug 29, 2024
Merged
@neekolas neekolas force-pushed the 08-28-save_blockchain_message branch from 9724bcf to 3c2bcb8 Compare August 29, 2024 05:06
@neekolas neekolas force-pushed the 08-28-rename_testing_to_testutils branch from 3eca2e7 to 3dca8b7 Compare August 29, 2024 05:06
@neekolas neekolas mentioned this pull request Aug 29, 2024
Merged
richardhuaaa
richardhuaaa approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@richardhuaaa richardhuaaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOVE this change, the naming conflict was super annoying

@neekolas Graphite App
Copy link
Contributor Author

neekolas commented Aug 29, 2024 •
edited
Loading

Merge activity

  • Aug 29, 4:23 PM PDT: @neekolas started a stack merge that includes this pull request via Graphite.
  • Aug 29, 4:25 PM PDT: Graphite rebased this pull request as part of a merge.
  • Aug 29, 4:27 PM PDT: @neekolas merged this pull request with Graphite.

@neekolas neekolas changed the base branch from 08-28-save_blockchain_message to graphite-base/121 August 29, 2024 23:23
@neekolas neekolas changed the base branch from graphite-base/121 to main August 29, 2024 23:23
@neekolas neekolas force-pushed the 08-28-rename_testing_to_testutils branch from 3dca8b7 to 60e6f13 Compare August 29, 2024 23:24
@neekolas neekolas merged commit 7f252c2 into main Aug 29, 2024
5 checks passed
@neekolas neekolas deleted the 08-28-rename_testing_to_testutils branch August 29, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardhuaaa richardhuaaa richardhuaaa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neekolas @richardhuaaa