Support for plugin options in java plugins #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suman-ganta
force-pushed
the
plugin-options-support
branch
from
629dd39
to
50e363e
Compare
|
@sergei-ivanov could you please check this out and provide your comments? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
<protocPlugin>hasargs,jvmArgs, but does not havepluginOptions. Plugin options are needed to pass any plugin specific options to the plugin. They are passed to the plugin as part of theCodeGeneratorRequestthat goes into the plugin via stdin. These options can be retrieved withCodeGeneratorRequest.getParameter()within the plugin.This PR adds support for pluginOptions. They are passed to protoc as
--<pluginId>_opt=<options>