Refactor script to improve readability

Removed Indirect filter, it is not necessary because the list of direct modules is prepared in advance. Split the GO_LIST_FORMAT_FOR_UPDATE variable into several lines, so it is easier to read and understand the meaning. Signed-off-by: Vasiliy Vasilyuk <[email protected]>
xorcare · Feb 6, 2024 · 58a9bca · 58a9bca
1 parent 3bd159e
commit 58a9bca
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/go-mod-bump.sh b/go-mod-bump.sh
@@ -39,14 +39,15 @@ GO_LIST_FORMAT_DIRECT='{{.Path}}{{if .Indirect}}<SKIP>{{end}}'
 readonly GO_LIST_FORMAT_DIRECT
 
 # shellcheck disable=SC2068
-DIRECT_MODULES=$(go list -f "$GO_LIST_FORMAT_DIRECT" -m $@ | grep -v '<SKIP>')
+DIRECT_MODULES=$(go list -m -f "$GO_LIST_FORMAT_DIRECT" $@ | grep -v '<SKIP>')
 readonly DIRECT_MODULES
 
-GO_LIST_FORMAT_FOR_UPDATE='{{.Path}}@{{.Version}}@{{if .Update}}{{.Update.Version}}{{else}}<SKIP>{{end}}{{if .Indirect}}<SKIP>{{end}}'
+GO_LIST_FORMAT_FOR_UPDATE='{{.Path}}@{{.Version}}@{{if .Update}}{{.Update.Version}}{{end}}'
+GO_LIST_FORMAT_FOR_UPDATE+='{{if not .Update}}<SKIP>{{end}}' # skip modules without updates.
 readonly GO_LIST_FORMAT_FOR_UPDATE
 
 # shellcheck disable=SC2086
-MODULES_FOR_UPDATE=$(go list -f "$GO_LIST_FORMAT_FOR_UPDATE" -m -u $DIRECT_MODULES | grep -v '<SKIP>')
+MODULES_FOR_UPDATE=$(go list -m -u -f "$GO_LIST_FORMAT_FOR_UPDATE" $DIRECT_MODULES | grep -v '<SKIP>')
 readonly MODULES_FOR_UPDATE
 
 function update_module() {