Bug fix with post scripts #40
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compiling a simple Hello World program generates assembly code that contains: # (external call) movl (sp), %esp # <REQ> movl $printf, (external) When using post/xor.py (and other post scripts), the corresponding instructions generated are: # (external call) #xor> movl (sp), %esp # <REQ> xorl %ebx, %ebx xorl (sp), %ebx xorl %esp # <REQ>, %ebx xorl %ebx, %esp # <REQ> The third instruction is the problematic: xorl %esp # <REQ>, %ebx The root cause is that the comment (# <REQ>) is also being identified as the "destination" register My change makes it discard the comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiling a simple Hello World program generates assembly code that contains:
When using post/xor.py (and other post scripts), the corresponding instructions generated are:
The third instruction is the problematic:
xorl %esp # <REQ>, %ebxThe root cause is that the comment (
# <REQ>) is also being identified as the "destination" registerMy change makes it discard the comment