Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nest "More from artist" menu entries in submenu #531

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

supremesnickers
Copy link
Contributor

@supremesnickers supremesnickers commented Jun 21, 2022

Previously, every listed artist had its own "More from artist" menu entry, this commit nests them in a submenu with each entry representing an artist. Songs with a single artist are not affected.

Submenu:
screenshot1

Entries in submenu:
screenshot2

);
}

menu.append_submenu(Some("More from"), &submenu);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these strings wont be translated -- you have to add a gettext call here, or I guess we could cheat and have labels::more_from_label("") here 🙈

Copy link
Owner

@xou816 xou816 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good :) sorry for the late review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants