Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to new reflection API #30

Merged
merged 4 commits into from
Jul 30, 2023
Merged

Migrate to new reflection API #30

merged 4 commits into from
Jul 30, 2023

Conversation

thekid
Copy link
Member

@thekid thekid commented Jul 29, 2023 •
edited
Loading

See xp-framework/rfc#338

Performance

Before:

$ xp test src/test/php/
# ...
Test cases:  177 succeeded
Memory used: 3676.30 kB (3730.42 kB peak)
Time taken:  0.031 seconds (0.096 seconds overall)

After:

$ xp test src/test/php/
# ...
Test cases:  177 succeeded
Memory used: 3621.24 kB (3675.37 kB peak)
Time taken:  0.034 seconds (0.107 seconds overall)

thekid
thekid commented Jul 30, 2023
View reviewed changes
src/main/php/inject/Injector.class.php
@@ -235,7 +226,7 @@ public function get($type, $name= null) {
/**
* Retrieve args for a given routine.
*
* @param lang.reflect.Routine $routine
* @param lang.reflection.Routine $routine
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a BC break and will require a major version release (6.0.0 at the time of writing).

@thekid thekid merged commit 413152c into master Jul 30, 2023
@thekid thekid deleted the refactor/reflection branch July 30, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@thekid