Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to new reflection library #24

Merged
merged 5 commits into from
Jul 25, 2023
Merged

Migrate to new reflection library #24

merged 5 commits into from
Jul 25, 2023

Conversation

thekid
Copy link
Member

@thekid thekid commented Jul 25, 2023

This pull request migrates the code to use xp-framework/reflection. As this changes the API, we will releases this as a major release, 4.0.0 at the time of writing.

Performance

No measurable impact.

Before

$ xp test src/test/php
# ...
Test cases:  121 succeeded, 1 skipped
Memory used: 4291.82 kB (4345.94 kB peak)
Time taken:  0.061 seconds (0.182 seconds overall)

After

$ xp test src/test/php
# ...
Test cases:  121 succeeded, 1 skipped
Memory used: 4406.82 kB (4496.78 kB peak)
Time taken:  0.064 seconds (0.188 seconds overall)

See also

@thekid thekid merged commit 41febbe into master Jul 25, 2023
@thekid thekid deleted the refactor/reflection branch July 25, 2023 20:35
@thekid
Copy link
Member Author

thekid commented Jul 25, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant