Merge pull request #51 from xp-framework/feature/logical-assignment

Logical Operators and Assignment Expressions
xp-framework · Mar 23, 2024 · 6924a08 · 6924a08
2 parents 399900f + a4b51f2
commit 6924a08
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/src/main/php/lang/ast/Tokens.class.php b/src/main/php/lang/ast/Tokens.class.php
@@ -16,8 +16,8 @@ class Tokens {
     '>' => ['>>=', '>=', '>>'],
     '=' => ['===', '=>', '=='],
     '!' => ['!==', '!='],
-    '&' => ['&&', '&='],
-    '|' => ['||', '|='],
+    '&' => ['&&=', '&&', '&='],
+    '|' => ['||=', '||', '|='],
     '^' => ['^='],
     '+' => ['+=', '++'],
     '-' => ['-=', '--', '->'],

diff --git a/src/main/php/lang/ast/syntax/PHP.class.php b/src/main/php/lang/ast/syntax/PHP.class.php
@@ -236,6 +236,8 @@ public function __construct() {
     $this->assignment('>>=');
     $this->assignment('<<=');
     $this->assignment('??=');
+    $this->assignment('&&=');
+    $this->assignment('||=');
 
     // This is ambiguous:
     //

diff --git a/src/test/php/lang/ast/unittest/parse/OperatorTest.class.php b/src/test/php/lang/ast/unittest/parse/OperatorTest.class.php
@@ -63,7 +63,7 @@ public function prefix($operator) {
     );
   }
 
-  #[Test, Values(['=', '+=', '-=', '*=', '/=', '.=', '**=', '&=', '|=', '^=', '>>=', '<<='])]
+  #[Test, Values(['=', '+=', '-=', '*=', '/=', '.=', '**=', '&=', '|=', '^=', '>>=', '<<=', '??=', '&&=', '||='])]
   public function assignment($operator) {
     $this->assertParsed(
       [new Assignment(new Variable('a', self::LINE), $operator, new Variable('b', self::LINE), self::LINE)],