Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add annotation type mappings to TARGET_ANNO detail #89

Merged
merged 2 commits into from
Sep 29, 2020
Merged

Add annotation type mappings to TARGET_ANNO detail #89

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe3a81b
QA: Documentation [skip ci]
thekid Sep 26, 2020
bbc250a
Add annotation type mappings to TARGET_ANNO detail
thekid Sep 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 31 additions & 14 deletions src/main/php/lang/ast/emit/PHP.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,10 +281,13 @@ protected function emitClass($result, $class) {
}

/** Stores lowercased, unnamespaced name in annotations for BC reasons! */
protected function emitAnnotations($result, $annotations) {
protected function annotations($result, $annotations) {
$lookup= [];
foreach ($annotations as $name => $arguments) {
$p= strrpos($name, '\\');
$result->out->write("'".lcfirst(false === $p ? $name : substr($name, $p + 1))."' => ");
$key= lcfirst(false === $p ? $name : substr($name, $p + 1));
$result->out->write("'".$key."' => ");
$name === $key || $lookup[$key]= $name;

if (empty($arguments)) {
$result->out->write('null,');
Expand All @@ -301,6 +304,25 @@ protected function emitAnnotations($result, $annotations) {
$result->out->write('],');
}
}
return $lookup;
}

/** Emits annotations in XP format - and mappings for their names */
protected function attributes($result, $annotations, $target) {
$result->out->write('DETAIL_ANNOTATIONS => [');
$lookup= $this->annotations($result, $annotations);
$result->out->write('], DETAIL_TARGET_ANNO => [');
foreach ($target as $name => $annotations) {
$result->out->write("'$".$name."' => [");
foreach ($this->annotations($result, $annotations) as $key => $value) {
$lookup[$key]= $value;
}
$result->out->write('],');
}
foreach ($lookup as $key => $value) {
$result->out->write("'".$key."' => '".$value."',");
}
$result->out->write(']');
}

/** Removes leading, intermediate and trailing stars from apidoc comments */
Expand All @@ -314,28 +336,23 @@ private function comment($comment) {
}
}

/** Emit meta information so that the reflection API won't have to parse it */
protected function emitMeta($result, $name, $annotations, $comment) {
if (null === $name) {
$result->out->write('\xp::$meta[strtr(self::class, "\\\\", ".")]= [');
} else {
$result->out->write('\xp::$meta[\''.strtr(ltrim($name, '\\'), '\\', '.').'\']= [');
}
$result->out->write('"class" => [DETAIL_ANNOTATIONS => [');
$this->emitAnnotations($result, $annotations);
$result->out->write('], DETAIL_COMMENT => '.$this->comment($comment).'],');
$result->out->write('"class" => [');
$this->attributes($result, $annotations, []);
$result->out->write(', DETAIL_COMMENT => '.$this->comment($comment).'],');

foreach (array_shift($result->meta) as $type => $lookup) {
$result->out->write($type.' => [');
foreach ($lookup as $key => $meta) {
$result->out->write("'".$key."' => [DETAIL_ANNOTATIONS => [");
$this->emitAnnotations($result, $meta[DETAIL_ANNOTATIONS]);
$result->out->write('], DETAIL_TARGET_ANNO => [');
foreach ($meta[DETAIL_TARGET_ANNO] as $target => $annotations) {
$result->out->write("'$".$target."' => [");
$this->emitAnnotations($result, $annotations);
$result->out->write('],');
}
$result->out->write('], DETAIL_RETURNS => \''.$meta[DETAIL_RETURNS].'\'');
$result->out->write("'".$key."' => [");
$this->attributes($result, $meta[DETAIL_ANNOTATIONS], $meta[DETAIL_TARGET_ANNO]);
$result->out->write(', DETAIL_RETURNS => \''.$meta[DETAIL_RETURNS].'\'');
$result->out->write(', DETAIL_COMMENT => '.$this->comment($meta[DETAIL_COMMENT]));
$result->out->write(', DETAIL_ARGUMENTS => [\''.implode('\', \'', $meta[DETAIL_ARGUMENTS]).'\']],');
}
Expand Down