Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the default XPath version implementation defined #1092

Merged
merged 2 commits into from
Jun 6, 2024
Merged

Conversation

ndw
Copy link
Contributor

@ndw ndw commented Apr 14, 2024

Closes issue 39 in the vnext repository.

@ndw ndw requested a review from a team as a code owner April 14, 2024 17:40
Copy link
Contributor

@gimsieke gimsieke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor typo

pipelines or libraries declare different XPath versions, it is
<glossterm>implementation-defined</glossterm> how those conflicts are resolved.</impl>
An implementation might use different versions for different pipelines, or it might
use the same version for all pipelines. <impl>If an implementation elects to us the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

us → use

@xml-project
Copy link
Member

I think this is a good solution for the inheritance problem. But I am not sure how it covers the problem when the pipeline is asking for an XPath version not supported by the processor. Does this PR suggest the reaction as implementation-defined?

@ndw
Copy link
Contributor Author

ndw commented Apr 15, 2024

Fixed the typo. Extended err:XS0110 to cover versions less than 3.1 or other versions unsupported by the processor.

@ndw ndw merged commit c5d47f4 into xproc:master Jun 6, 2024
2 checks passed
@ndw ndw deleted the vnext-39 branch June 6, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants