-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add area
endpoint support
#49
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #49 +/- ##
==========================================
+ Coverage 79.02% 81.64% +2.62%
==========================================
Files 6 7 +1
Lines 205 267 +62
==========================================
+ Hits 162 218 +56
- Misses 43 49 +6 ☔ View full report in Codecov by Sentry. |
Love when code coverage goes down from adding more tests lol |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this generally looks good, but select.py
and it's functions are a little more complicated to follow than it feels like it should be for the length of the file (especially thinking ahead if we add other geometry types).
I think it would be easier to follow if each geometry had it's own file, partially because you could more easily compare between geometries, and it would separate geometry specific logic from common shared logic.
- select_common.py
- area.py
- position.py
- query_params.py
Some tweaks of names might help as well.
Agree with this feedback, especially because I want to add multipoint support next which further complicates things I'll do some cleaning before merging :) |
@abkfenris Let me know how you feel about this reorg |
@mpiannucci Much easier to follow, thank you. |
area
endpoint