Add CRS support for queries #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcherian
reviewed
Nov 12, 2024
mpiannucci
commented
Nov 14, 2024
dcherian
reviewed
Nov 14, 2024
mpiannucci
commented
Nov 14, 2024
|
This is ready for a review as a first implementation |
dcherian
reviewed
Nov 15, 2024
dcherian
reviewed
Nov 15, 2024
dcherian
reviewed
Nov 15, 2024
dcherian
reviewed
Nov 15, 2024
dcherian
reviewed
Nov 15, 2024
dcherian
reviewed
Nov 15, 2024
dcherian
reviewed
Nov 15, 2024
| always_xy=True, | ||
| ) | ||
|
|
||
| # TODO: Handle rotated pole |
There was a problem hiding this comment.
i thought we figured this out.
There was a problem hiding this comment.
This only matters if the user has input a rotated coord system as the target coordinate system. Which i may be comfortable ignoring for now...
dcherian
reviewed
Nov 15, 2024
dcherian
reviewed
Nov 15, 2024
Co-authored-by: Deepak Cherian <[email protected]>
Co-authored-by: Deepak Cherian <[email protected]>
Co-authored-by: Deepak Cherian <[email protected]>
Co-authored-by: Deepak Cherian <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #58 +/- ##
==========================================
+ Coverage 79.02% 86.66% +7.64%
==========================================
Files 6 11 +5
Lines 205 390 +185
==========================================
+ Hits 162 338 +176
- Misses 43 52 +9 ☔ View full report in Codecov by Sentry. |
abkfenris
approved these changes
Nov 15, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires CF grid mapping on the target dataset, otherwise nothing is projected
cc @dcherian